Fix patch set replacement emails to correctly retain reviewers
This was an ordering problem, we looked for the old reviewers after
their prior approval bits had already been squashed to 0. That
meant we called them CC's only, and didn't mention them as one of
the change's reviewers when we sent out a patch set replacement
notice. By moving this selection code into receive, before we do
the squash to 0, we can be certain we pick the right folks.
Also, we no longer mention that the sender is one of the reviewers
to should be greeted at the start of the email. It just looks odd
to see yourself asking yourself for a code review, but its fairly
common to have given your own change a +1 Verified approval mark.
Signed-off-by: Shawn O. Pearce <sop@google.com>
2 files changed
