commit | 06ef4a7dfa15569a3c4fe919d826562efddd37bc | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Tue Dec 03 13:25:56 2019 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Wed Dec 04 08:36:08 2019 +0100 |
tree | a54d6ba56b506c969ca233614561560950b632e8 | |
parent | a1b7855be7224ca0cb5f5063fe9faace6dc2a83c [diff] |
Document that positive votes on design docs are sticky For design docs it is often the case that people vote with Code-Review+1 to express their consent with the contents, but then these votes get lost when minor issues such as nits, spelling mistakes, rephrasing, adding some more points are addressed. Reviewers which already gave their consent often don't come back after each iteration to re-apply their Code-Review+1 vote, so that in the end it can look like there is not much support for a design, while in fact many people agreed to it (and just their Code-Review+1 votes are no longer visible). This makes it more difficult to reason about approving a design by the ESC. To improve this situation change I357351cd0 makes all positive Code-Review votes in the homepage repo sticky. To prevent that significant changes that are made by new patch sets stay unnoticed it is the responsibility of the uploader to manually remove all positive votes in this case. This change documents this. Bug: Issue 12025 Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I09177d70e1a19755cab228a83dacea7175cbdfa7
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.