| commit | 06997ba71fa5e36bc5815327acf44f5ca07d5d32 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Apr 05 11:05:51 2023 +0000 |
| committer | Nasser Grainawi <nasser.grainawi@linaro.org> | Wed Apr 05 18:37:25 2023 +0000 |
| tree | eb0781758e6a432d17a8ffa90e57b85da47c681c | |
| parent | 4f12dcc3748e195a8bd788bc382fb3deb70c4e71 [diff] |
DefaultMemoryCacheFactoryTest: Fix flaky test shouldRunEvictionListenerInThreadPool checks that a cache invalidation triggers the ForwardingRemovalTrackerListener. At the moment it does: 1. put a value into the cache 2. invalidate the value in the cache 3. assert that the ForwardingRemovalTrackerListener has not been invoked yet 4. wait for the cache eviction to happen 5. assert that the ForwardingRemovalTrackerListener has been invoked This test is flaky because often it happens that the cache eviction that is triggered by 2. is already done before the assertion in 3. is checked. Fix this by swapping steps 2. and 3.: 1. put a value into the cache 2. assert that the ForwardingRemovalTrackerListener has not been invoked 3. invalidate the value in the cache 4. wait for the cache eviction to happen 5. assert that the ForwardingRemovalTrackerListener has been invoked Release-Notes: skip Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I1ec5e15fd94c8d9b3029d60423ca464112f868fe (cherry picked from commit bbe60a253f5f607fd82a74536813b698ddf80c9c) (cherry picked from commit 8308428d87bacbe43bf8eaab505543a40340c259)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.