commit 0633ae11fb432af4992beda468d87863c075b408
author Dhruv Srivastava <dhruvsri@google.com> Thu Nov 11 15:16:47 2021 +0100
committer Dhruv Srivastava <dhruvsri@google.com> Fri Nov 12 11:47:00 2021 +0100
tree de3c553e3c637bb71e8f402a82b96b1e87a7a4ed
parent 676a42d537f5a9d0c6fe70574b07279a134f11a3

Refactor navigateToChange to take options

Instead of specifying 5 undefined parameters if we want to do a force
reload, specify the necessary parameter only.

Change-Id: Ibae0a57c29f115ef3fdb5c7d381ff1b350b2775d

polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts

diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
index 2360312..5518767 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
@@ -185,13 +185,9 @@
             if (this._query.match(queryPattern)) {
               // "Back"/"Forward" buttons work correctly only with
               // opt_redirect options
-              GerritNav.navigateToChange(
-                changes[0],
-                undefined,
-                undefined,
-                undefined,
-                true
-              );
+              GerritNav.navigateToChange(changes[0], {
+                redirect: true,
+              });
               return;
             }
           }

polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view_test.js

diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view_test.js b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view_test.js
index 86b2fd1..03b6858 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view_test.js
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view_test.js
@@ -181,9 +181,9 @@
           .returns(Promise.resolve([change]));
       const promise = mockPromise();
       sinon.stub(GerritNav, 'navigateToChange').callsFake(
-          (url, opt_patchNum, opt_basePatchNum, opt_isEdit, opt_redirect) => {
+          (url, opt) => {
             assert.equal(url, change);
-            assert.isTrue(opt_redirect);
+            assert.isTrue(opt.redirect);
             promise.resolve();
           });
 
@@ -197,9 +197,9 @@
           .returns(Promise.resolve([change]));
       const promise = mockPromise();
       sinon.stub(GerritNav, 'navigateToChange').callsFake(
-          (url, opt_patchNum, opt_basePatchNum, opt_isEdit, opt_redirect) => {
+          (url, opt) => {
             assert.equal(url, change);
-            assert.isTrue(opt_redirect);
+            assert.isTrue(opt.redirect);
             promise.resolve();
           });
 
@@ -213,9 +213,9 @@
           .returns(Promise.resolve([change]));
       const promise = mockPromise();
       sinon.stub(GerritNav, 'navigateToChange').callsFake(
-          (url, opt_patchNum, opt_basePatchNum, opt_isEdit, opt_redirect) => {
+          (url, opt) => {
             assert.equal(url, change);
-            assert.isTrue(opt_redirect);
+            assert.isTrue(opt.redirect);
             promise.resolve();
           });