| commit | 05a2398d89d74615f24ece5e0cb8e0dffeca9fdd | [log] [tgz] |
|---|---|---|
| author | Tao Zhou <taoalpha@google.com> | Fri May 29 08:00:56 2020 +0000 |
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Fri May 29 08:00:56 2020 +0000 |
| tree | 735b7bb03bca1fd59742e7e6d53a2f614d782d58 | |
| parent | 927512cd0fb03ebb267d85f390fa4fd17e2e3655 [diff] | |
| parent | f809f36328a7293189db71ed5f8049c298ad8101 [diff] |
Merge "Update arial label for gr-change-star button"
diff --git a/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star.js b/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star.js index 886f0c1..dac1755 100644 --- a/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star.js +++ b/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star.js
@@ -53,6 +53,10 @@ return `gr-icons:star${starred ? '' : '-border'}`; } + _computeAriaLabel(starred) { + return starred ? 'Unstar this change' : 'Star this change'; + } + toggleStar() { const newVal = !this.change.starred; this.set('change.starred', newVal);
diff --git a/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star_html.js b/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star_html.js index f723717a..3b7b1af 100644 --- a/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star_html.js +++ b/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star_html.js
@@ -37,7 +37,11 @@ ); } </style> - <button aria-label="Change star" on-click="toggleStar"> + <button + role="checkbox" + aria-label="[[_computeAriaLabel(change.starred)]]]" + on-click="toggleStar" + > <iron-icon class$="[[_computeStarClass(change.starred)]]" icon$="[[_computeStarIcon(change.starred)]]"