commit 04e6dbcc568c9ef47b5b62bffc7f677169b1b4fc
author Sven Selberg <svense@axis.com> Fri Mar 29 13:50:59 2019 +0100
committer Sven Selberg <svense@axis.com> Fri Mar 29 14:04:40 2019 +0100
tree 76e698e8696df32506d8bada72ad6030bcc0c6ab
parent 2a00d73389f2ebd637bf785c624b93bdf3db7914

CommitValidation: Keep relaying warning messages from validators

In 5eb0219 - Set logging tag with plugin name on invocation of ...
Running onCommitRecieved for all CommitValidationListeners was
refactored from a for-loop to PluginSetContex#runEach.
Adding messages from the successful validations was lost in the
process.

Bug: Issue 10666
Change-Id: If81489b38b107a5f04c33b398fb554ac2516776f

java/com/google/gerrit/server/git/validators/CommitValidators.java

diff --git a/java/com/google/gerrit/server/git/validators/CommitValidators.java b/java/com/google/gerrit/server/git/validators/CommitValidators.java
index b228267..c6d26b5 100644
--- a/java/com/google/gerrit/server/git/validators/CommitValidators.java
+++ b/java/com/google/gerrit/server/git/validators/CommitValidators.java
@@ -487,7 +487,8 @@
       List<CommitValidationMessage> messages = new ArrayList<>();
       try {
         commitValidationListeners.runEach(
-            l -> l.onCommitReceived(receiveEvent), CommitValidationException.class);
+            l -> messages.addAll(l.onCommitReceived(receiveEvent)),
+            CommitValidationException.class);
       } catch (CommitValidationException e) {
         messages.addAll(e.getMessages());
         throw new CommitValidationException(e.getMessage(), messages);