List Branches: Make processing with start/limit params more performant
The 'List Branches' project rest endpoint has a 'limit' parameter.
Regardless of whether or not it's used, we open the repository, load all
branches, and check for the user's visibility over all branches.
We rework the implementation such that we do the following
1) Get all branches
2) Filter out branches that don't match 'matchPrefix', 'matchRegex'
3) Iteratively loop over remaining refs, check for visibility until we
get a fill of 'limit' count (taking 'start' param into account)
Unfortunately, for 'start' parameters that are larger than zero, we need
to check visibility of refs up to the 'start' value, and only then start
populating the output list until we get a 'limit' number of refs. This
means that requests with large 'start' will be less performant, but at
least we improve over the status quo, where all requests check
visibility for all refs.
We also had to rework the sorting implementation of refs to ensure this
change is a noop: Previously we performed the sorting as follows:
1) Get all branches, filter for visibility
2) Sort the o/p list
3) Filter it out again according to start, limit, substring, regex
Since we now process branches iteratively, and to maintain the same
ordering, we now perform the ordering on the initial input list of all
branches. This is same since (sort then filter) is equivalent to
(filter then sort).
Google-Bug-Id: b/288895555
Release-Notes: skip
Change-Id: I2016e5c205a6daf2d4d87021d18ac1590eb685bc
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.