commit e2f9a3ec75625d47038de8574ba9719e7aeb8ae6
author David Ostrovsky <david@ostrovsky.org> Fri Jan 22 23:10:49 2021 +0100
committer David Ostrovsky <david.ostrovsky@gmail.com> Sun Feb 14 21:45:44 2021 +0000
tree 3c6e1486b160de629bae5ee236922f72eff14e0b
parent 41623da45ec6b2fdd21a4012fdd31a34db4e6379

uploadPackAuditEventLog: Avoid commit timestamp mismatch

JGit's TestRepository instance uses a mocked system reader with a mocked
time source:

  now = Aug 15 20:12:58 GMT-03:30 2009

That's why the new upstream commit has a commit time 11 years in the
past. However, when a new repository is created, an empty commit is
created per default without using the mocked system reader. When second
commit is created, using TestRepository, then we have the following
situation:

root commit   timestamp: 1611269860
second commit timestamp: 1250379779

Until now we don't really care, but in the recent JGit version git wire
protocol v2 is used per default for fetching. When trying to upgrade to
this new JGit version, we supposed to change the number of requests
required to fetch new commit from remote repository from 2 to 3.

However due to timestamp skew between root commit and second commit 4
requests are required. Even though, the want commit is present in the
repository, it's not found in UploadPack.wantSatisfied() method because
of commit TimeRev filter:

  if (oldestTime != 0)
      walk.setRevFilter(CommitTimeRevFilter.after(oldestTime * 1000L));

Because the common base commit timestamp is older than the second
commit, commit TimeRev filter prevents the want commit to be found.
As the consequence the fetch command isn't finishing with three requests
and an additional request is required.

To rectify, skip empty commit during project creation, and create
common commit using TestRepository instead. That way the same mocked
system reader is used for both commits.

This is the fix for JGit update change: I00fd18587c.

Change-Id: Idd60394b8d3453c3b61fec292867f28a5532aa8b