| commit | 02e281d9d30d5abbf22e66cd9ab8c670adf3d554 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Oct 05 11:39:09 2017 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Oct 05 12:28:15 2017 +0200 |
| tree | 5fdfa39107c5b09fe5938a7805c60c974163f841 | |
| parent | 8dac226947f82962a403ba109243e35347568150 [diff] |
Trigger GitReferenceUpdated event when external IDs are updated When external IDs are updated the refs/meta/external-ids branch in the All-Users repository is updated. For this update we must trigger a GitReferenceUpdated event, so that e.g. this ref update gets replicated to Gerrit slaves. PostGpgKeys and GpgKeys are now injected as provider into GpgApiAdapterImpl to avoid a circular Guice dependency: GitReferenceUpdated needs EventUtil which needs ChangeJson.Factory. ChangeJson uses GpgApiAdapter to find out if push certificates are enabled and if yes to include the push certicates of the patch set uploaders into RevisionInfo. This doesn't require PostGpgKeys and GpgKeys. If PostGpgKeys would be injected without provider we would need ExternalIdsUpdate.User to instantiate it which now needs GitReferenceUpdated. Hence without injecting PostGpgKeys into GpgApiAdapterImpl as a provider we would have a dependency circle. Change-Id: Ia9c71d26669f24f20c659d82ae97ecfca6ab61c3 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.