Google Git
Sign in
gerrit / gerrit / de94bbe0d3ba35ae4358b3b5a2786175c548c298
commitde94bbe0d3ba35ae4358b3b5a2786175c548c298[log] [tgz]
authorBen Rohlfs <brohlfs@google.com>Wed Nov 29 10:41:11 2023 +0100
committerBen Rohlfs <brohlfs@google.com>Wed Nov 29 16:03:52 2023 +0100
tree9ab5d320ce969ada1c936e491718ea620bf13fb5
parent9950dc244cad81b1356d58eb05fc7c41d42aab9d [diff]
Fix `COMMENT` route for change numbers with unknown repo

The `RestApiService` has a cached map for looking up the repo by
change number. This is usually populated in either the router's
`setState()` method or when change information was fetched from the
Rest API.

The `COMMENT` route is special, because it requires dedicated Rest
API calls for looking up where to redirect the user. This happens
before `setState()` is executed. Thus the repo lookup cache is not
yet populated. There is a fallback of looking up the repo by making
an index query, which was working ok until 3.7 (just making routing
a bit slower than desired), but this fallback won't work, if the
repo was imported and change numbers are not unique across the
entire Gerrit instance.

So the easy fix is to manually populate the repo cache in
`handleCommentRoute()` before making any Rest API calls.

Release-Notes: Fix comment directly link pointing to a change imported from other Gerrit server-ids
Bug: Issue 312895375
Change-Id: I2fc29df3f29718b47a019d4a82b6b4abaf52e69f
1 file changed
tree: 9ab5d320ce969ada1c936e491718ea620bf13fb5
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. MODULE.bazel
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.