Inline getSaveButtonLabel Save button is never rendered when editing is false. Release-Notes: skip Google-bug-id: b/242982372 Change-Id: I0a7b6738ae04ffb66716b5dd49b1fa099872148e
diff --git a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts index e96c8fe..7eecc23 100644 --- a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts +++ b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts
@@ -834,7 +834,7 @@ ?disabled=${this.isSaveDisabled()} class="action save" @click=${this.handleSaveButtonClicked} - >${this.getSaveButtonLabel()}</gr-button + >${this.permanentEditingMode ? 'Preview' : 'Save'}</gr-button > `; } @@ -1066,11 +1066,6 @@ }); } - private getSaveButtonLabel() { - if (!this.permanentEditingMode) return 'Save'; - return this.editing ? 'Preview' : 'Edit'; - } - private handleSaveButtonClicked() { if (!this.permanentEditingMode) this.save(); else this.editing = !this.editing;