commit | 0032b6818d17d5b622031ccf3331aba8da1be7ee | [log] [tgz] |
---|---|---|
author | Youssef Elghareeb <ghareeb@google.com> | Wed Jul 21 14:07:07 2021 +0200 |
committer | Youssef Elghareeb <ghareeb@google.com> | Thu Jul 22 11:46:24 2021 +0200 |
tree | e916dba00a9c6b550845dcfa2d2a927bb242d950 | |
parent | b54da87ee10f1ffee942f5896774d72bd656e594 [diff] |
Adjust FileInfoJson to accept 1-based integers for parent There was a discrepancy between parent representations in DiffOperations and FileInfoJson: The former used to accept 1-based parents, while the latter accepted 0-based parents. There was a programming bug in FilesInCommitCollection, since this API accepts a value "0" for parent to indicate the default or auto-merge commit (See documentation in [1]). The bug happened because we passed `parent - 1` (=-1) to FileInfoJson resulting in array out of bounds while resolving the parent commit. In this change we fix this bug. We unify the parent representation in DiffOperations and FileInfoJson such that they both accept a 1-based representation for parents. Also adding javadoc to clarify this. We also remove the @Nullable from DiffOperations and use a primitive integer with 0 to represent the default/auto-merge. We update all callers to pass 0 instead of null. [1] https://gerrit-review.googlesource.com/Documentation/rest-api-projects.html#list-files Change-Id: Ic10d6e925b2b0e1db295997f5e28c10a085874a9
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.