| commit | 002b9ee7b3dd78489edcfed8e0769ecb4a41aa9f | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Wed Sep 10 11:06:39 2014 +0200 |
| committer | David Pursehouse <david.pursehouse@sonymobile.com> | Wed Oct 01 21:39:08 2014 +0900 |
| tree | 96874f89b5a5e98800ca3803f74ebf3bc24b2409 | |
| parent | b35d0e120886fdf3a202c7470702a6fbf337b99e [diff] |
Avoid CodeReviewCommit.error() whenever possible The instances returned by this static factory method are severely limited, in that they are not tied to actual commit objects. In most cases, we can tie them to commit objects, so do that whenever possible. Limit the statuses that we can pass to this method by making it private, and creating separate factories only for those statuses where there is really no commit. Change-Id: I0cb392f4f7f5134d4a7487a2a7bb7ac9d770f334