| commit | e02812b521d09a314af95f2804c69d2d1cef67df | [log] [tgz] |
|---|---|---|
| author | Jacek Centkowski <geminica.programs@gmail.com> | Thu Feb 29 15:28:06 2024 +0100 |
| committer | Jacek Centkowski <geminica.programs@gmail.com> | Mon Mar 25 19:21:57 2024 +0100 |
| tree | 123d0d32c5fb69964c2d390423ebbb0616f94eef | |
| parent | cfb8342b5014eb7cd078df6f3f3362758d0e8c99 [diff] |
Fix starred changes clash after repo import from another site Introduce `virtualId` to change data and initiate it with the `legacy_id_str` from the index so that changes list screen (which is populated from the index only) could be properly updated with star bit. Ensure that `changeServerId` is loaded from notes when notes are available in the `ChangeData`. Finally use the `virtualId` in all calls to get/set starred changes so that the refs clash is avoided. As a result the starred changes ref gets modified to the following form: refs/starred-changes/NN/<virtual-id>/<account-id> where `virtual-id` is `server-id` encoded `change-id` for imported changes and `change-id` for existing/newly created ones. Issue 331016670: to be addressed as the follow-up - toggle star from changes list screen doesn't work for imported changes - the problem is that UI uses change.id to obtain the project first which clashes with existing changes. It works fine on the single change screen. Bug: Issue 325309573 Release-Notes: Starred changes clash when importing changes from another instance Forward-Compatible: checked Change-Id: I85c946efcab5d20dd25682cb758bb9601c93b1d2
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.