| commit | da8a2ad40293c0070502ae2818ff3685cd10cae6 | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Sun Oct 13 23:18:00 2019 +0200 |
| committer | David Ostrovsky <david@ostrovsky.org> | Mon Oct 14 10:39:15 2019 +0200 |
| tree | 2b6f3d74d2e8d5c270463f2a06822c2fb7af979e | |
| parent | 5044de0330b8ed421fca21c8ff61560fca020657 [diff] |
Rewrite OS bean provider to avoid using reflection
Try to cast the OperatingSystemMVBean to unix instance and in success
case use that instance directly instead of reflection based approach.
Given that 99% of gerrit instances are used on linux based systems
in production, we can avoid reflection access altogether and thus
administrators wouldn't need to pass:
--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED
option on newer Java versions.
Test Plan (on *nix system):
1. Build gerrit to produce Java lanuage level 11:
$ bazel build --host_javabase=@bazel_tools//tools/jdk:remote_jdk11 \
--javabase=@bazel_tools//tools/jdk:remote_jdk11 \
--host_java_toolchain=@bazel_tools//tools/jdk:toolchain_java11 \
--java_toolchain=@bazel_tools//tools/jdk:toolchain_java11 \
:release
2. Init new gerrit site
3. Run gerrit site with Java 11
4. Confirm that it can be started and works as expected without passing
--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED
option.
Bug: Issue 7843
Change-Id: I712d3fab05b267fa4ab5b3ba17247287aebebcb6
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.