| commit | cbf312f854e38f963ab0dc2fb3f2e62c6e9e3975 | [log] [tgz] |
|---|---|---|
| author | Prudhvi Akhil Alahari <prudhvi.alahari@linaro.org> | Thu Nov 03 20:15:52 2022 +0530 |
| committer | Prudhvi Akhil Alahari <prudhvi.alahari@linaro.org> | Fri Nov 04 00:39:18 2022 +0530 |
| tree | 408d59d6ded6aed07a0ee0c397a862f0272ca865 | |
| parent | 731a0e1e919aa5503a0c96fd441b6cea7228c3a0 [diff] |
Fix index rewriter to rewrite all Or/AndPredicates
ChangeIndexRewriter processes predicate tree to group all index
predicates into one at each level. Rewriter starts from root node
and traverses to all the child nodes. Rewriter recursively marks each
child predicate as indexed or nonindexed. Then it partitions all the
indexed predicates together and also rewrites And/OrPredicates to
either a source or a cardinal predicate. Before this change, rewriter
short-circuits the partitioning & skips rewrite logic when there is
only one indexed child. Due to this behavior, query [2] was not
rewritten to OrCardinal predicate since (status:open OR status:merged)
is one indexed child at its level (as in [3]), whereas query [1] was
rewritten to AndCardinal.
[1] status:open age:1d issue:123
[2] (status:open OR status:merged) issue:123
[3] root
/ \
Or issue:123
/ \
open merged
Fix index rewriter to run the rewrite logic to rewrite Or/AndPredicate
to respective cardinal predicates when it short-circuits. This helps
AndSource to choose the right source more often. Also fix few tests
to assert on OrCardinalPredicate rather than OrPredicate.
Unfortunately there are no operators which are datasources other
than Index in the Core as of now. We at Qualcomm have a datasource
operator in a plugin which takes a bug number and queries the bug
tracker's DB for changes related to that bug number. Suppose this
operator (say issue:123) returns around 15 changes. On a 3.4 test site
against LUCENE which contains ~20K open changes, ~2.8M merged changes,
the performance of,
query "(status:open OR status:merged) issue:123"
before: 6m52s, 6m40s, 6m36s
after: 0.07s, 0.07s, 0.07s
Release-Notes: AndSource chooses right source more often
Change-Id: I87311359e28795d5f461b233cecd82ecaf53ee57
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.