commit | c46d2c9310e4606582f65efa4492dc14e0e36f73 | [log] [tgz] |
---|---|---|
author | Luca Milanesio <luca.milanesio@gmail.com> | Thu Jun 13 14:39:16 2024 +0100 |
committer | Luca Milanesio <luca.milanesio@gmail.com> | Thu Jun 13 15:15:05 2024 +0000 |
tree | 18bc236714badc6fd8c2d298882c23c2c7921279 | |
parent | ba868a93d4e9685e0b93025a0a6e342a0f132d74 [diff] |
Fix permission backend extra query with parens During the review the If144832047b4 the way the extra query added by the permission backend was overlooked and, in conjunction of a an empty query in the integration test allowed the following ambiguity: Query without permissions backend limitations - author:self OR status:open => returns all open changes or authored by the current user Query with a permissions backend hiding a testHiddenProject - author:self OR status:open -project:testHiddenProject The above query is not doing what the permission backend would expect, because is evaluated as follows: - author:self OR (status:open AND -project:testHiddenProject) The above query would return all changes authored by the current user, including the ones of testHiddenProject. Release-Notes: Fix evaluation of extra query provided by a permission backend Change-Id: I94dea44d5c5f00a9a90c29136cf265d4759b2165
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.