| commit | bd9a623ce0a6eb0b0e9e73d4da8513ec8d57d203 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Jun 13 09:27:29 2024 +0000 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Jun 13 10:39:23 2024 +0000 |
| tree | 467ce945b25e13518fe0de03420c60ed970b24a6 | |
| parent | 2d29658dc8f4e6f60d751ba558a8e5cc41e86c4c [diff] |
Remove etags for ListFiles REST endpoint Change Ia92fbad2a and change Ic54db5dc9 remove etags for change and revision resources because the etag computation is too expensive to bring any latency benefits. The same is true for the ListFiles etag, i.e. it includes the expensive change and revision etag computation. An etag is only returned if the REST endpoint returns a response with cache control, see RestApiServlet#configureCaching which calls RestApiServlet#addResourceStateHeaders that sets the etag in the response. For ListFiles this is only the case if a concrete revision number is specified, but not for the magic "current" revision. Etags are mostly relevant for UI's that do auto-refreshing via polling. PolyGerrit uses the ListFiles REST endpoint (with a concrete revision number) but fetches the file list only once when the change is loaded and then doesn't do any polling for it, i.e. it never makes use of the etag that is returned by ListFiles. For other callers (mostly service users) it's unlikely that they do polling with etags, especially since the etag support for this REST endpoint is not even documented [1]. Hence having ListFiles return etags likely doesn't have any benefits, but calculating them can add up to 1.2s to ListFiles requests, just for including the etag into the response. [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-files Release-Notes: Removed etags for ListFiles REST endpoint Bug: Google b/336400432 Change-Id: Ib49748bfbdde6c69cf215a95c8edbdc33f9db4a8 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.