Use project and changeNum for listing files in a patch-set
The ListFiles REST-API for listing files included in a patch-set
was relying on a lookup by change number only, which would fail
when the change is imported from a different Gerrit server-id.
Also, the lookup by change number alone would need a reverse
lookup in Lucene, whilst using the project as well would skip
that step and will be therefore faster.
It is unclear to me why the project name was not used, and
there is little comments, explanation or discussion associated
with the change that introduced this regression (see I1bb2ff2).
See for example the change [1] has the project name in the URL
and can be discovered as expected, however, the listing of
the files of the patch-set 1 failed because the lookup happened
using only the change number 5819 internally, resulting in
404 popup errors.
Example:
````
GET /changes/5819/files
```
Use both project and changeNum in the lookup and return the
list of files more reliably.
[1] https://eclipse.gerrithub.io/c/eclipse-jgit/jgit/+/5819
Release-Notes: Support listing of patch-set files also for imported projects
Change-Id: I0ccd90cf6aac2a60baa9ea45f30bebac7cfdd318
diff --git a/java/com/google/gerrit/server/restapi/change/Files.java b/java/com/google/gerrit/server/restapi/change/Files.java
index e996169..e89cf6c 100644
--- a/java/com/google/gerrit/server/restapi/change/Files.java
+++ b/java/com/google/gerrit/server/restapi/change/Files.java
@@ -173,7 +173,7 @@
} else if (parentNum != 0) {
int parents =
gApi.changes()
- .id(resource.getChange().getChangeId())
+ .id(resource.getChange().getProject().get(), resource.getChange().getChangeId())
.revision(resource.getPatchSet().id().get())
.commit(false)
.parents
