| commit | 6104d86a8fe6ae1cfe3e4d2f86204abaa5e15a62 | [log] [tgz] |
|---|---|---|
| author | Dmitrii Filippov <dmfilippov@google.com> | Wed Jun 12 16:56:26 2024 +0200 |
| committer | Dmitrii Filippov <dmfilippov@google.com> | Thu Jun 13 07:00:36 2024 +0000 |
| tree | 81ee58b6eb46c059ac90787683e8831e565733e8 | |
| parent | 7d0bad4e4791ec8785cf8629561acd7497b9385e [diff] |
Reject command instead of internal error when deleting non-existing ref. The Git CLI sends DELETE 0...0 0...0 command (i.e. 0 old id) when it can't get ref from server during negotiation phase. It is unclear why this happens, but it always causes internal error in gerrit even if the ref actually exists. This change explicitly checks old id in the delete command and reject it with a correct message. The fix doesn't have tests, because jgit never sends DELETE command to a server if server doesn't return it during negotiation. Writing tests require a lot of low-level operation to create and pass the command to gerrit - this is too complicated comparing to the value of fix itself. The change was tested by commenting some jgit code to emulate the behavior of Git CLI. It was confirmed, that: 1) Gerrit always fail if old id is 0 (both for existing and non-existing repos) 2) After the fix, the command is rejected with a correct message. Google-Bug-Id: b/345164807 Release-Notes: skip Change-Id: Icafbbdb12a2950d34c957a893c2a4b8587c393c6
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.