Google Git
Sign in
gerrit / gerrit.git / 5e56ebcb3096e9bf18b65996b700a6e0bb264020
commit5e56ebcb3096e9bf18b65996b700a6e0bb264020[log] [tgz]
authorAntonio Barone <syntonyze@gmail.com>Wed Jun 12 16:36:14 2024 +0200
committerAntonio Barone <syntonyze@gmail.com>Wed Jun 12 17:55:15 2024 +0200
tree375ebb214b5ce72e7720610101973129ef266246
parenta63562c103840a11632cf08cecc3dfd07897f379 [diff]
Fix reloading of plugins registering dynamic items

When change Ia7ed2a06ec3 refactored the `Plugin` hierarchy by
introducing different plugin specifications, omitted to inherit the
`reloadableHandles` from the parent class and instead, introduced a new
`reloadableHandles` variable in the `JarPlugin` implementation.

This caused the `Plugin.getReloadableHandles()` to always return an
empty list, effectively preventing the reloading of the plugin from
replacing existing reloadable bindings [1] and creating new ones
instead.

Whilst this still allows the `reload` to succeed, it misses the removal
of the registration handle associated with the old plugin instance,
which will then not be de-registered if the new plugin is disabled later
on.

Inherit `reloadableHandles` from the parent `Plugin` class so that
addition and retrieval of reloadable registration handles targets the
same instance variable, allowing the reload to move existing dynamic
registration handles to the new plugin instance, rather than creating a
new one.

[1] https://gerrit.googlesource.com/gerrit/+/refs/heads/stable-3.8/java/com/google/gerrit/server/plugins/PluginGuiceEnvironment.java#305

Bug: Issue 346618790
Release-Notes: Fix reload of plugins causing incorrect deregistration of dynamic items
Change-Id: I13896cf1fcabebc26d465aec7c8debc9dddb11be
2 files changed
tree: 375ebb214b5ce72e7720610101973129ef266246
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.