Google Git
Sign in
gerrit / gerrit.git / 5b3805a73936deabbafbfdb930df1b16b5b28670
commit5b3805a73936deabbafbfdb930df1b16b5b28670[log] [tgz]
authorJacek Centkowski <jcentkowski@collab.net>Mon Apr 20 16:00:00 2020 +0200
committerDavid Pursehouse <dpursehouse@digital.ai>Wed Apr 29 14:14:33 2020 +0900
tree5a440aa67b0a36c8ceb98c387c5ba73c79dc5353
parent59c7671b85ad00d8825d6280816ddd875b323982 [diff]
Fix 'visibleto' predicate for group

Issue:
When one uses a valid group name in 'visibleto' predicate no change
gets returned even if it should be from the access perspective.

Solution:
It boils down to the problem in ChangeIsVisibleToPredicate for
SingleGroupUser user - it is not an IdentifiedUser hence it gets
swapped for AnonymousUser and visibility check fails unless changes
in question are granted to Anonymous Users group. Fix it to let it
use the user it has in case it is SingleGroupUser or follow existing
user resolution (with fallback to anonymous) as it was before.

Bug: Issue 12606
Change-Id: Ieea8abf4b52d528d4cb2503270c7eff68476fc6c
2 files changed
tree: 5a440aa67b0a36c8ceb98c387c5ba73c79dc5353
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. e2e-tests/
  6. gerrit-gwtdebug/
  7. gerrit-gwtui/
  8. gerrit-gwtui-common/
  9. gerrit-plugin-gwtui/
  10. java/
  11. javatests/
  12. lib/
  13. plugins/
  14. polygerrit-ui/
  15. prolog/
  16. prologtests/
  17. proto/
  18. resources/
  19. tools/
  20. webapp/
  21. .bazelignore
  22. .bazelproject
  23. .bazelrc
  24. .bazelversion
  25. .editorconfig
  26. .git-blame-ignore-revs
  27. .gitignore
  28. .gitmodules
  29. .gitreview
  30. .mailmap
  31. .pydevproject
  32. .zuul.yaml
  33. BUILD
  34. COPYING
  35. INSTALL
  36. Jenkinsfile
  37. package.json
  38. README.md
  39. SUBMITTING_PATCHES
  40. version.bzl
  41. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.