| commit | 1423ad32f4e9a2a8181bbfa41c13d4b012ade346 | [log] [tgz] |
|---|---|---|
| author | Milutin Kristofic <milutin@google.com> | Thu Jun 27 11:10:10 2024 +0200 |
| committer | Paladox none <thomasmulhall410@yahoo.com> | Fri Jun 28 08:15:33 2024 +0000 |
| tree | b8d265b3b4d2fa2486055f3a2689192290bfef27 | |
| parent | cb763a2028bda1e7f6632e8923000256b941e8c7 [diff] |
Fix Attach AI fixes on Save Button click Change 420297 introduced bug what AI fixes are not added to draft object when user clicks on Save button; they are added only by auto-save, so it works when auto-save is triggered, but not on quick comments where user clicks on save. This change removes the buggy code that caused the issue of not attaching AI fixes after user clicks on Save. Save() is setting editing to false before calling somethingToSave() which calls isFixSuggestionChanged(). So editing is always false in isFixSuggestionChanged called by save() and it makes no sense to return false when !this.editing in isFixSuggestionChanged(). Added unit tests that check adding AI fixes on user clicks. One fails without this change. Google-Bug-Id: b/343632982 Release-Notes: skip Change-Id: Ic404fa17285d97b56b2f8d222f064b9f0780ec67 (cherry picked from commit ac2576d5b70c9130e5627d7524d721269c7bb2b5)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.