Merge "Prefactor of GrChangeView"
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts
index ce7898b..38657ff 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts
@@ -1220,6 +1220,10 @@
this.$.fileList.collapseAllDiffs();
}
+ _diffPrefsChanged(e: ValueChangedEvent<DiffPreferencesInfo>) {
+ this._diffPrefs = e.detail.value;
+ }
+
/**
* ChangeView is never re-used for different changes. It is safer and simpler
* to just re-create another change view when the user switches to a new
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_html.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_html.ts
index dfa1903..c6fa903 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_html.ts
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_html.ts
@@ -302,7 +302,7 @@
<div
id="mainContent"
class="container"
- hidden$="{{_loading}}"
+ hidden$="[[_loading]]"
aria-hidden="[[_changeViewAriaHidden]]"
>
<section class="changeInfoSection">
@@ -379,7 +379,7 @@
<div class="changeInfo-column changeMetadata hideOnMobileOverlay">
<gr-change-metadata
id="metadata"
- change="{{_change}}"
+ change="[[_change]]"
reverted-change="[[revertedChange]]"
account="[[_account]]"
revision="[[_selectedRevision]]"
@@ -520,8 +520,8 @@
server-config="[[_serverConfig]]"
shown-file-count="[[_shownFileCount]]"
diff-prefs="[[_diffPrefs]]"
- patch-num="{{_patchRange.patchNum}}"
- base-patch-num="{{_patchRange.basePatchNum}}"
+ patch-num="[[_patchRange.patchNum]]"
+ base-patch-num="[[_patchRange.basePatchNum]]"
files-expanded="[[_filesExpanded]]"
diff-prefs-disabled="[[!_loggedIn]]"
on-open-diff-prefs="_handleOpenDiffPrefs"
@@ -533,7 +533,7 @@
<gr-file-list
id="fileList"
class="hideOnMobileOverlay"
- diff-prefs="{{_diffPrefs}}"
+ diff-prefs="[[_diffPrefs]]"
change="[[_change]]"
change-num="[[_changeNum]]"
patch-range="[[_patchRange]]"
@@ -544,6 +544,7 @@
on-files-shown-changed="_setShownFiles"
on-file-action-tap="_handleFileActionTap"
observer-target="[[_computeObserverTarget()]]"
+ on-diff-prefs-changed="_diffPrefsChanged"
>
</gr-file-list>
</div>
@@ -666,7 +667,7 @@
<template is="dom-if" if="[[replyOverlayOpened]]">
<gr-reply-dialog
id="replyDialog"
- change="{{_change}}"
+ change="[[_change]]"
patch-num="[[_computeLatestPatchNum(_allPatchSets)]]"
permitted-labels="[[_change.permitted_labels]]"
draft-comment-threads="[[_draftCommentThreads]]"
