Google Git
Sign in
gerrit / gerrit.git / 3c2593b85829af4b4f8cb6f6153f06e96f91017b
commit3c2593b85829af4b4f8cb6f6153f06e96f91017b[log] [tgz]
authorTao Zhou <taoalpha@google.com>Mon Jun 22 14:49:05 2020 +0200
committerPaladox none <thomasmulhall410@yahoo.com>Fri Jul 03 14:58:57 2020 +0000
tree9f4936dbd5b36c099554e2f316a7dd8e5ec89301
parent2b8c5b8aa6b7165a2eec158284b93a8ff90941c4 [diff]
Fix selection on diff with range comments

Due to the way we annotating the lines, the hovering will
recreate the line which will clear the selection.

The fix is for hovering changes, skip the annotation process,
and do the style changing in the mouse move listeners.

Since the gr-ranged-comment-layer has no access or knowledge
to the thread or the line, I decided to do the style change
in the gr-diff-highlight where we are listening the mouse events.

Bug: Issue 12934
Change-Id: Ia3186a5034ad26b01d8c7f071508ac7ad2dd12d6
(cherry picked from commit da95b8c408ded58a77f5550f58f8cc7aa9ef3d93)
3 files changed
tree: 9f4936dbd5b36c099554e2f316a7dd8e5ec89301
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. e2e-tests/
  6. java/
  7. javatests/
  8. lib/
  9. modules/
  10. plugins/
  11. polygerrit-ui/
  12. prolog/
  13. prologtests/
  14. proto/
  15. resources/
  16. tools/
  17. webapp/
  18. polymer-bridges
  19. .bazelignore
  20. .bazelproject
  21. .bazelrc
  22. .bazelversion
  23. .editorconfig
  24. .git-blame-ignore-revs
  25. .gitignore
  26. .gitmodules
  27. .gitreview
  28. .mailmap
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. package.json
  36. README.md
  37. SUBMITTING_PATCHES
  38. version.bzl
  39. WORKSPACE
  40. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.