Google Git
Sign in
gerrit / gerrit.git / 15f592c83c4896f7967edbd9a956f284b7160923
commit15f592c83c4896f7967edbd9a956f284b7160923[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Tue May 28 14:00:22 2024 +0000
committerEdwin Kempin <ekempin@google.com>Fri May 31 08:39:30 2024 +0000
treef71a167048e6837678a468d0780d5386421fc7f7
parentb82fcd7581a1a98910b1f30a0b724e7eaddc692e [diff]
Increase maximum weight for the project list cache to fix data race

The project list cache uses Caffeine. For Caffeine caches the configured
maximum weight may be temporarily exceeded while evicting. If this
happens Caffeine increases the cache size in a non-thread-safe way which
can cause a data race. To prevent this from happening we must set the
maximum weight high enough so that resizing during eviction is not
necessary. From internal tests that detect data races we see that the
cache size may be increased to 4, and setting 4 as the maximum weight
fixes the data race.

This problem has been reported to the Caffeine team:
https://github.com/ben-manes/caffeine/issues/1698

Release-Notes: skip
Bug: Google b/306907433
Change-Id: I7581f3b73ebf9027011ab8a9033447d98e75b661
Signed-off-by: Edwin Kempin <ekempin@google.com>
1 file changed
tree: f71a167048e6837678a468d0780d5386421fc7f7
  1. .github/
  2. .settings/
  3. .ts-out/
  4. antlr3/
  5. contrib/
  6. Documentation/
  7. e2e-tests/
  8. java/
  9. javatests/
  10. lib/
  11. modules/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. proto/
  17. resources/
  18. tools/
  19. webapp/
  20. polymer-bridges
  21. .bazelignore
  22. .bazelproject
  23. .bazelrc
  24. .bazelversion
  25. .editorconfig
  26. .git-blame-ignore-revs
  27. .gitignore
  28. .gitmodules
  29. .gitreview
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. MODULE.bazel
  37. package.json
  38. README.md
  39. SUBMITTING_PATCHES
  40. version.bzl
  41. web-dev-server.config.mjs
  42. WORKSPACE
  43. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.