Google Git
Sign in
gerrit / gerrit.git / 151701ea407ff53caf0eec737d2e92546bdd66ec
commit151701ea407ff53caf0eec737d2e92546bdd66ec[log] [tgz]
authorKamil Musin <kamilm@google.com>Thu Jun 13 12:39:07 2024 +0200
committerKamil Musin <kamilm@google.com>Thu Jun 13 16:12:24 2024 +0200
treec1944206b447b763180110d72938d6e57af9dfaa
parent017ef1b0650ace8348e81f285124b87749f2a1e8 [diff]
Add ChangeKind for trivial rebase with commit message update.

ChangeKind is used when defining rules, that control whether or not the
vote is copied, after the new patchset have been uploaded. It's common
configuration for both TRIVIAL_REBASE and NO_CODE_CHANGE (commit message
update) to not invalidate votes. Adding this extra value allows to
changes that do both actions to also not invalidate votes. While in
principle such change can be split in two, sometimes the edit to commit
message is the result of the tooling and therefore not easily avoidable.

At the same time, we don't want to simply change the definition of the
TRIVIAL_REBASE, since some repos might prefer commit changes to cause a
re-review.

Additionally we add the unit tests to the ChangeKindCacheImpl for both
new and old usecases, since they were missing before.

Also update the ChangeKind returned, when both `prior` and `next` are
the same ObjectId. The only reason why it's NO_CODE_CHANGE currently is
because, at the time it was added (Ie04d0282e) NO_CHANGE didn't yet
exist, and it hasn't been adjusted since.

Google-Bug-Id: b/324626345
Release-Notes: Add TRIVIAL_REBASE_WITH_MESSAGE_UPDATE ChangeKind to
  allow automatic vote copy in this case
Change-Id: I23dfdfc42aa2f08fd647fc0dd1b5e2e45ea5dad8
8 files changed
tree: c1944206b447b763180110d72938d6e57af9dfaa
  1. .github/
  2. .settings/
  3. .ts-out/
  4. antlr3/
  5. contrib/
  6. Documentation/
  7. e2e-tests/
  8. java/
  9. javatests/
  10. lib/
  11. modules/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. proto/
  17. resources/
  18. tools/
  19. webapp/
  20. polymer-bridges
  21. .bazelignore
  22. .bazelproject
  23. .bazelrc
  24. .bazelversion
  25. .editorconfig
  26. .git-blame-ignore-revs
  27. .gitignore
  28. .gitmodules
  29. .gitreview
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. MODULE.bazel
  37. package.json
  38. README.md
  39. SUBMITTING_PATCHES
  40. version.bzl
  41. web-dev-server.config.mjs
  42. WORKSPACE
  43. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.