commit 65582f2deb4c0e020ff04016cf23862b76d3d42b
author Thomas Draebing <thomas.draebing@sap.com> Tue Aug 25 13:12:04 2020 +0200
committer Thomas Draebing <thomas.draebing@sap.com> Tue Aug 25 13:20:11 2020 +0200
tree df7a510291dc860408c759914dfaf050d6500b5c
parent f5c4885e674ffb634ee8291872668c2247c2f3bf

Also monitor parallel GC

This change

- adds metrics for parallel GC to the GC panel in the Gerrit Process
  dashboard
- configures the GC panel to only show queries with values other than
  null
- changes the interval to one minute, which fits the scrape interval
- changes the default time frame to the last 24h, which is used for
  most other dashboards

Change-Id: I3b6587e769ae7486a02e26b8d7f2822319eb94e6

dashboards/gerrit-process.json

diff --git a/dashboards/gerrit-process.json b/dashboards/gerrit-process.json
index fd76368..046f688 100644
--- a/dashboards/gerrit-process.json
+++ b/dashboards/gerrit-process.json
@@ -333,6 +333,8 @@
         "alignAsTable": true,
         "avg": true,
         "current": true,
+        "hideEmpty": true,
+        "hideZero": true,
         "max": true,
         "min": true,
         "rightSide": false,
@@ -358,6 +360,14 @@
         {
           "alias": "gc time G1 young gen",
           "color": "#3274D9"
+        },
+        {
+          "alias": "gc time PS Scavange",
+          "color": "#8AB8FF"
+        },
+        {
+          "alias": "gc time PS MarkSweep",
+          "color": "#E02F44"
         }
       ],
       "spaceLength": 10,
@@ -366,13 +376,31 @@
       "targets": [
         {
           "expr": "increase(proc_jvm_gc_time_G1_Young_Generation{instance=\"$instance\",replica=\"$replica\"}[2m])/increase(proc_uptime{instance=\"$instance\",replica=\"$replica\"}[2m])",
+          "interval": "1m",
+          "intervalFactor": 1,
           "legendFormat": "gc time G1 young gen",
           "refId": "B"
         },
         {
           "expr": "increase(proc_jvm_gc_time_G1_Old_Generation{instance=\"$instance\",replica=\"$replica\"}[2m])/increase(proc_uptime{instance=\"$instance\",replica=\"$replica\"}[2m])",
+          "interval": "1m",
+          "intervalFactor": 1,
           "legendFormat": "gc time G1 old gen",
           "refId": "A"
+        },
+        {
+          "expr": "increase(proc_jvm_gc_time_PS_MarkSweep{instance=\"$instance\",replica=\"$replica\"}[2m])/increase(proc_uptime{instance=\"$instance\",replica=\"$replica\"}[2m])",
+          "interval": "1m",
+          "intervalFactor": 1,
+          "legendFormat": "gc time PS MarkSweep",
+          "refId": "C"
+        },
+        {
+          "expr": "increase(proc_jvm_gc_time_PS_Scavenge{instance=\"$instance\",replica=\"$replica\"}[2m])/increase(proc_uptime{instance=\"$instance\",replica=\"$replica\"}[2m])",
+          "interval": "1m",
+          "intervalFactor": 1,
+          "legendFormat": "gc time PS Scavange",
+          "refId": "D"
         }
       ],
       "thresholds": [],
@@ -768,7 +796,7 @@
     ]
   },
   "time": {
-    "from": "now-6h",
+    "from": "now-24h",
     "to": "now"
   },
   "timepicker": {
@@ -788,5 +816,5 @@
   "timezone": "",
   "title": "Process",
   "uid": "MeOVgCPWz",
-  "version": 4
+  "version": 5
 }