Google Git
Sign in
gerrit/gerrit-fe-dev-helper/bc2b3fe9f49bddafc0396bee72d8620a248aa3eb
commit
bc2b3fe9f49bddafc0396bee72d8620a248aa3eb
[log]
author
Ben Rohlfs <brohlfs@google.com>
Wed Nov 29 10:35:18 2023 +0100
committer
Ben Rohlfs <brohlfs@google.com>
Mon Dec 04 11:15:46 2023 +0100
tree
bb39943499cfa027589e24943832a264268230a3
parent
619b1197c4cb892f7c0ed29d4610c908d972d873 [diff]
Migrate to Manifest V3: Replace blocking web request listeners

We are following this migration guide:
https://developer.chrome.com/docs/extensions/migrating/blocking-web-requests/

In a nutshell Chrome does not allow request/response manipulation
anymore programmatically: You cannot hook up a listener and do whatever
you like adhoc. Instead you have to register declarative manipulation
rules. This suits us quite well, because we already have declarative
rules defined by the user.

So we are removing all the listeners and the adhoc manipulation, and
instead we are adding conversion logic from our own `Rule` interface
to Chrome's `chrome.declarativeNetRequest.Rule`.

Then we only have to listen to `chrome.storage` updates and call
`updateRules()`, which will do the conversion and make sure that
Chrome's rules are in sync with the user's rules.

We are also removing default rules being fetched from a URL. Instead we
believe that using the default rules that were shipped with the current
version of the extension is more robust, and simpler to maintain.

Google-Bug-Id: b/287605771
Change-Id: I92548878dd82067ed6e14cf9102d6dc51379c56d
6 files changed
tree: bb39943499cfa027589e24943832a264268230a3
  1. data/
  2. src/
  3. webpack/
  4. .gitignore
  5. .prettierrc
  6. demo.png
  7. package-lock.json
  8. package.json
  9. README.md
  10. release-notes.md
  11. tsconfig.json
README.md

Gerrit FE Dev Helper

Gerrit FE Dev helper is a Chrome extension that will focus on helping frontend developers on Gerrit development.

As mentioned in readme from polygerrit-ui, we already support to start your local host for developing / debugging / testing, but it has quite a few restrictions:

  1. No auth support
  2. Restart needed to switch hosts
  3. Not easy to test plugins

To solve these pain points, Tao Zhou created this Chrome extension. It proxies all assets requests or any requests to a local HTTP server, and has the ability to inject any plugins exposed by the local HTTP server.

Features

See in release notes and Features below.

Install

The easiest is to install from the Chrome web store here: https://chrome.google.com/webstore/detail/gerrit-fe-dev-helper/jimgomcnodkialnpmienbomamgomglkd.

After you have installed and enabled the extension, you should see something similar to demo.png.

BUILD

To build from source:

npm install
npm run build

Then you should have gerrit_fe_dev_helper.zip that you can test with.

How to use

  1. For Gerrit core development, start the local Gerrit dev server to host app code locally
yarn start

Or if you are developing a plugin, serve your plugin via a local HTTP server via any means.

Example:

npx http-server -c-1 --cors
  1. Go to any Gerrit sites, enable the extension by clicking the icon
  2. You should see a red notice show up in the bottom right of the page: Gerrit dev helper is enabled, and now your Gerrit assets should be loaded from your local HTTP server
  3. Change files locally and refresh the page, you should have the changes immediately

The extension comes with a set of default rules, but you can change the rules by clicking the extension icon again.

The extension supports six different type of rules:

  1. block: block a certain request
  2. redirect: redirect a url to another url
  3. injectHtmlCode: inject a piece of html code to the page
  4. injectJsCode: inject any js code to the page
  5. injectJsPlugin: inject a js plugin(url) to the site
  6. injectHtmlPlugin: inject a html plugin(url) to the site
  7. injectJsModule: inject a js module file to the site (type=“module” will be added when load script)
  8. addReqHeader: to add arbitrary header when you send a request
  9. addRespHeader: to add arbitrary header when you receive a request
  10. rRespHeader: to remove arbitrary header on any response

The two options to inject any plugins (injectJsPlugin and injectHtmlPlugin) are meant to help you develop your plugins for your Gerrit sites. As they are served from your local HTTP server, you do not need to deploy them on the target Gerrit server.

How to use dev helper with html plugins

Use injectHtmlPlugin rule or use redirect rule if its an existing html plugin.

How to use dev helper with js plugins

For single-file js plugins, use injectJsPlugin rule or use redirect if its an exising js plugin.

For multi-file modularized js plugins (you have import / export in source code), you have two options:

  1. compile them and then treat it as single-file js plugin
  2. or if you want to load source code as it is
  • use injectJsModule, this will load the js with type="module", and due to restriction of type="module", Gerrit won't be able to recognize the plugin without a proper url set when calling Gerrit.install, so you also need to tweak your code to call Gerrit.install(callback, undefined, 'http://localhost:8081/plugins_/checks/gr-checks/gr-checks.js') to let Gerrit treat it as a legit plugin
  • or you can create a temporary html plugin which loads the http://localhost:8081/plugins_/checks/gr-checks/gr-checks.js with type="module", and then treat it as a html plugin

Either way, you need to block the existing plugin if its already on the page.

Testing a new version

  • Execute npm run build.
  • Go to chrome://extensions/.
  • Turn on Developer Mode.
  • Click Load Unpacked.
  • Choose the dist directory.

As a Google developer you will have to add a key to the manifest.json in the dist/ directory as documented here: http://go/extension-identification#i%E2%80%99m-developing-a-chrome-extension-on-my-computer

Publish a new version to the Chrome Webstore

This section is for members of Google's developer team only.

Contact

Please don't hesitate to contact dhruvsri@google.com for support on this extension.