| commit | 473892102c88c7f5a7c04b93286c7e06a01328f5 | [log] [tgz] |
|---|---|---|
| author | Luca Milanesio <luca.milanesio@gmail.com> | Sat May 16 02:10:52 2020 +0100 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Sat May 16 02:10:52 2020 +0100 |
| tree | 37fd1679982a850ff48af0df77658a8d9b59c935 | |
| parent | 9898b43a5c869e50e438d286f18b3399b7e51d79 [diff] |
Always run //Documentation:check_licenses on PolyGerrit validations The recent breakage on Gerrit master (see [1]) has highlighted the need of running the check of the license file also for the PolyGerrit-only changes. In [1] the removal of a library (moment.js) was not accompanied with the update of the Gerrit licenses and therefore broke the build. The breakage wasn't reported by the CI because the total set of tests is skipped for PolyGerrit-only changes. The license file generated and included in the Gerrit documentation set is dependent on the NodeJS packages included in the PolyGerrit components. [1] https://gerrit-review.googlesource.com/c/gerrit/+/266035 Change-Id: I8c5de7fe1478f6c924dd9e38420a7bdb68ac4d3f
This project uses Jenkins Jobs Builder [1] to generate jobs from yaml descriptor files.
To add new jobs reuse existing templates, defaults etc. as much as possible. E.g. adding a job to build an additional branch of a project may be as easy as adding the name of the branch to an existing project.
To ensure well readable yaml-files, use yamllint [2] to lint the yaml-files. Yamllint can be downloaded using Python Pip:
pip3 install yamllint
To run the linter, execute this command from the project's root directory:
yamllint -c yamllint-config.yaml jenkins/**/*.yaml
Yamllint will not fix detected issues itself.
[1] https://docs.openstack.org/infra/jenkins-job-builder/index.html [2] https://pypi.org/project/yamllint/