Remove pointless catch of ProvisionExeption in IdentifiedUser
About the only way this can be raised here is if the database pool
just took longer than 30 seconds to obtain you a database connection.
In 30 seconds, the user has gone away and is no longer waiting for
this request to finish anyway, so logging and using an empty list
is stupid. And, if your pool is out of connections, users will
start screaming at the admin, fast, because a whole lot of things
are going to stop responding on the site. I've seen it happen on
our internal server a few times, and it doesn't take long to be told
its non-responsive. Don't even need to check the logs. Gerrit is
normally so fast that any response time over 1 or 2 seconds starts
to trigger a user's "something is wrong" flag.
Change-Id: I48575f6306598f9464b1ec3beefa26eca0c83399
Signed-off-by: Shawn O. Pearce <sop@google.com>
1 file changed
