commit 68d022d29372240c9a4ccee48966c6fdc6bd3a3d
author David Ostrovsky <david@ostrovsky.org> Sat May 31 09:58:48 2014 +0200
committer David Ostrovsky <david@ostrovsky.org> Sun Jun 01 07:29:56 2014 +0200
tree a901ece9d2b61a0bc6bf073f118dd81b25d65cc6
parent 99035bc2ba139a2a6bfa32d1a727038aef561749

Remove usage of genfile()

genfile() is dead: [1]; replace it.

[1] https://groups.google.com/forum/#!topic/buck-build/Ci8Y95USD8I

Change-Id: I6ff978761ca50c1a0e7cda1a487c208da1ec4d16

local_jar.bucklet

diff --git a/local_jar.bucklet b/local_jar.bucklet
index e123ae2..a7bd35b 100644
--- a/local_jar.bucklet
+++ b/local_jar.bucklet
@@ -49,8 +49,7 @@
       out = srcjar)
     prebuilt_jar(
       name = name + '_src',
-      deps = [':' + name + '__local_src'],
-      binary_jar = genfile(srcjar),
+      binary_jar = ':' + name + '__local_src',
       visibility = visibility,
     )
   else:
@@ -58,8 +57,8 @@
 
   prebuilt_jar(
     name = name,
-    deps = deps + [':' + name + '__local_bin'],
-    binary_jar = genfile(binjar),
-    source_jar = genfile(srcjar) if srcjar else None,
+    deps = deps,
+    binary_jar = ':' + name + '__local_bin',
+    source_jar = ':' + name + '__local_src' if srcjar else None,
     visibility = visibility,
   )

maven_jar.bucklet

diff --git a/maven_jar.bucklet b/maven_jar.bucklet
index c909470..bd68184 100644
--- a/maven_jar.bucklet
+++ b/maven_jar.bucklet
@@ -116,8 +116,7 @@
     )
     prebuilt_jar(
       name = name + '_src',
-      binary_jar = genfile(srcjar),
-      deps = [':' + name + '__download_src'],
+      binary_jar = ':' + name + '__download_src',
       visibility = visibility,
     )
   else:
@@ -128,13 +127,12 @@
       out = '__' + name + '__no_src',
     )
 
-  srcdep = [':' + name + '__download_src'] if srcjar else []
   if exported_deps:
     prebuilt_jar(
       name = name + '__jar',
-      deps = deps + srcdep + [':' + name + '__download_bin'],
-      binary_jar = genfile(binjar),
-      source_jar = genfile(srcjar) if srcjar else None,
+      deps = deps,
+      binary_jar = ':' + name + '__download_bin',
+      source_jar = ':' + name + '__download_src' if srcjar else None,
     )
     java_library(
       name = name,
@@ -144,8 +142,8 @@
   else:
     prebuilt_jar(
       name = name,
-      deps = deps + srcdep + [':' + name + '__download_bin'],
-      binary_jar = genfile(binjar),
-      source_jar = genfile(srcjar) if srcjar else None,
+      deps = deps,
+      binary_jar = ':' + name + '__download_bin',
+      source_jar = ':' + name + '__download_src' if srcjar else None,
       visibility = visibility,
     )