| commit | 82dba4843cebf36bd35d27071559800c6fd1a8de | [log] [tgz] |
|---|---|---|
| author | Michael Bolin <mbolin@fb.com> | Wed Sep 04 10:14:43 2013 -0700 |
| committer | Michael Bolin <mbolin@fb.com> | Thu Sep 19 15:05:16 2013 -0700 |
| tree | 1bd16bdeabe998cdbc2e5d6bd511b2082c52a807 | |
| parent | 61615c45fe601a188e46407db730f8acf07eb70a [diff] |
Fix some build cache interaction issues in AndroidResourceRule.
Summary:
(1) `AndroidResourceRule` was writing its output to `buck-out/bin`
instead of `buck-out/gen`. This was causing the following check
in `AbstractCachingBuildRule` to fail:
```
if (pathToOutputFile != null && pathToOutputFile.startsWith(BuckConstant.GEN_DIR)) {
String prefix = BuckConstant.GEN_DIR + '/' + getBuildTarget().getBasePathWithSlash();
buildInfoRecorder.recordArtifact(pathToOutputFile.substring(prefix.length()));
}
```
After fixing this for `AndroidResourceRule`, I manually inspected the
`getPathToOutputFile()` method in all build rules, and verified that
if a non-null value was returned, it started with `buck-out/gen`.
(2) `AndroidResourceRule` had two fields that were not being included in its RuleKey.
Test Plan: Sandcastle builds.
Buck is an Android build tool. To see what Buck can do for you, check out the documentation at http://facebook.github.io/buck/.
To build Buck, run the following:
git clone git@github.com:facebook/buck.git cd buck ant ./bin/buck --help
Apache License 2.0