Extract the shouldPost condition into own method
This improves readability of the event processing code.
Change-Id: Ic90fac6f16d0804669e0a772ea5f99eb5c24d6f8
diff --git a/src/main/java/com/googlesource/gerrit/plugins/webhooks/EventHandler.java b/src/main/java/com/googlesource/gerrit/plugins/webhooks/EventHandler.java
index d501cf4..49eca88 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/webhooks/EventHandler.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/webhooks/EventHandler.java
@@ -68,21 +68,24 @@
continue;
}
- String[] eventTypes = cfg.getStringList("remote", name, "event");
-
- if (eventTypes.length == 0) {
+ if (shouldPost(projectEvent, cfg.getStringList("remote", name, "event"))) {
post(url, projectEvent);
}
+ }
+ }
- for (String type : eventTypes) {
- if (Strings.isNullOrEmpty(type)) {
- continue;
- }
- if (type.equals(projectEvent.getType())) {
- post(url, projectEvent);
- }
+ private boolean shouldPost(ProjectEvent projectEvent, String[] wantedEvents) {
+ if (wantedEvents.length == 0) {
+ return true;
+ }
+
+ for (String type : wantedEvents) {
+ if (!Strings.isNullOrEmpty(type) && type.equals(projectEvent.getType())) {
+ return true;
}
}
+
+ return false;
}
private void post(final String url, final ProjectEvent projectEvent) {
