commit 5b80b3a2304cb38a786f1d3379415f4dd2849782
author Edwin Kempin <edwin.kempin@sap.com> Tue Sep 16 09:33:31 2014 +0200
committer Edwin Kempin <edwin.kempin@sap.com> Tue Sep 16 09:37:38 2014 +0200
tree ee2afe87dec96fe25af98061accba6ea485c7c3f
parent ef32091e8c23593f5bfda4f4c027523bde6e5e44

Do the project iteration on Gerrit startup in background

On Gerrit startup the plugin iterates over all projects and schedules
for each project a background job to scan for project-specific
download commands. Although the actual scanning is done in background
the iteration over all projects and the scheduling of the background
jobs may take a long time. Improve the Gerrit startup time by moving
the iteration over all projects into a background job that then does
the scanning for project-specific download commands on all projects.

Change-Id: I38e6005568f990ec816f4af43f40cb77091a2483
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>

src/main/java/com/googlesource/gerrit/plugins/download/command/project/DownloadCommandUpdater.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/download/command/project/DownloadCommandUpdater.java b/src/main/java/com/googlesource/gerrit/plugins/download/command/project/DownloadCommandUpdater.java
index 125426e..ce0f857 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/download/command/project/DownloadCommandUpdater.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/download/command/project/DownloadCommandUpdater.java
@@ -73,12 +73,22 @@
 
   @Override
   public void start() {
-    for (Project.NameKey p : projectCache.all()) {
-      ProjectState projectState = projectCache.get(p);
-      if (projectState != null) {
-        installCommandAsync(projectState);
+    executor.submit(new Runnable() {
+      @Override
+      public void run() {
+        for (Project.NameKey p : projectCache.all()) {
+          ProjectState projectState = projectCache.get(p);
+          if (projectState != null) {
+            PluginConfig cfg =
+                projectState.getConfig().getPluginConfig(pluginName);
+            for (String name : cfg.getNames()) {
+              installCommand(projectState.getProject().getNameKey(), name,
+                  cfg.getString(name));
+            }
+          }
+        }
       }
-    }
+    });
   }
 
   @Override
@@ -117,18 +127,6 @@
     }
   }
 
-  private void installCommandAsync(final ProjectState p) {
-    executor.submit(new Runnable() {
-      @Override
-      public void run() {
-        PluginConfig cfg = p.getConfig().getPluginConfig(pluginName);
-        for (String name : cfg.getNames()) {
-          installCommand(p.getProject().getNameKey(), name, cfg.getString(name));
-        }
-      }
-    });
-  }
-
   private void installCommand(final Project.NameKey p, String name,
       final String command) {
     ProjectDownloadCommand dc = projectDownloadCommands.get(name);