commit b54edcbfdb83bad18a2d228e37f283a0413e3aed
author Martin Fick <mfick@codeaurora.org> Mon Jul 09 17:59:53 2012 -0700
committer gerrit code review <noreply-gerritcodereview@google.com> Mon Jul 09 17:59:53 2012 -0700
tree c08f4183fa45c912cb311720f2219512251db37a
parent 3faf35d32e5727cb6f18b5ec949361547259e3e1
parent 870d4afa482882a2490afbfbf3209e55825cc744

Merge "Add helloworld print docs"

.gitignore

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..fb96bc0
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,5 @@
+/target
+/.classpath
+/.settings
+/.project
+

pom.xml

diff --git a/pom.xml b/pom.xml
index 8f94171..f1df7e1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -24,39 +24,44 @@
   <packaging>jar</packaging>
   <version>0.1</version>
   <properties>
-    <gerrit-version>2.4-rc0-139-gcaccf0f</gerrit-version>
+    <Gerrit-ApiType>plugin</Gerrit-ApiType>
+    <Gerrit-ApiVersion>2.5-SNAPSHOT</Gerrit-ApiVersion>
   </properties>
-  <name>Hello World Gerrit Plugin</name>
-  <url>https://gerrit-review.googlesource.com</url>
-
-  <description>
-    A hello world-type plugin example for Gerrit
-  </description>
 
   <build>
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-jar-plugin</artifactId>
+        <version>2.4</version>
+        <configuration>
+          <archive>
+            <manifestEntries>
+              <Gerrit-SshModule>com.google.gerrit.plugins.HelloWorldCommandModule</Gerrit-SshModule>
+
+              <Implementation-Vendor>Gerrit Code Review</Implementation-Vendor>
+              <Implementation-URL>http://code.google.com/p/gerrit/</Implementation-URL>
+
+              <Implementation-Title>Plugin ${project.artifactId}</Implementation-Title>
+              <Implementation-Version>${project.version}</Implementation-Version>
+
+              <Gerrit-ApiType>${Gerrit-ApiType}</Gerrit-ApiType>
+              <Gerrit-ApiVersion>${Gerrit-ApiVersion}</Gerrit-ApiVersion>
+            </manifestEntries>
+          </archive>
+        </configuration>
+      </plugin>
+
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
+        <version>2.3.2</version>
         <configuration>
           <source>1.6</source>
           <target>1.6</target>
           <encoding>UTF-8</encoding>
         </configuration>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-jar-plugin</artifactId>
-        <configuration>
-          <archive>
-            <manifestEntries>
-              <Gerrit-Plugin>helloworld</Gerrit-Plugin>
-              <Gerrit-SshModule>com.google.gerrit.plugins.HelloWorldCommandModule</Gerrit-SshModule>
-              <Gerrit-Version>${gerrit-version}</Gerrit-Version>
-            </manifestEntries>
-          </archive>
-        </configuration>
-      </plugin>
     </plugins>
     <resources>
       <resource>
@@ -71,8 +76,9 @@
   <dependencies>
     <dependency>
       <groupId>com.google.gerrit</groupId>
-      <artifactId>gerrit-plugin-api</artifactId>
-      <version>${gerrit-version}</version>
+      <artifactId>gerrit-${Gerrit-ApiType}-api</artifactId>
+      <version>${Gerrit-ApiVersion}</version>
+      <scope>provided</scope>
     </dependency>
   </dependencies>
 
@@ -82,5 +88,4 @@
       <url>https://gerrit-api.commondatastorage.googleapis.com/snapshot/</url>
     </repository>
   </repositories>
-
 </project>

src/main/java/com/google/gerrit/plugins/HelloWorldCommandModule.java

diff --git a/src/main/java/com/google/gerrit/plugins/HelloWorldCommandModule.java b/src/main/java/com/google/gerrit/plugins/HelloWorldCommandModule.java
index 4e52cbd..770c6f3 100644
--- a/src/main/java/com/google/gerrit/plugins/HelloWorldCommandModule.java
+++ b/src/main/java/com/google/gerrit/plugins/HelloWorldCommandModule.java
@@ -14,10 +14,11 @@
 
 package com.google.gerrit.plugins;
 
-import com.google.gerrit.sshd.commands.PluginCommandModule;
+import com.google.gerrit.sshd.PluginCommandModule;
 
 public class HelloWorldCommandModule extends PluginCommandModule {
-  public void configureCommands() {
+  @Override
+  protected void configureCommands() {
     command("print").to(PrintHelloWorldCommand.class);
   }
 }