commit 851f936db7b8ca841df1fc3c87a7d1c02b377c54
author Makson Lee <cdlee123@gmail.com> Sat Apr 22 08:47:35 2017 +0000
committer Makson Lee <cdlee123@gmail.com> Sun Apr 23 00:06:09 2017 +0000
tree 385af5e9a5be65d25b073eb49aa2f9b5a323e510
parent 6d71a874196acc80793062342ed9ec78f137899b

Make SimpleDateFormat thread safe

Change-Id: I36c7edea69eff13b1bcc88bb80001f17f4cbc4ac

src/main/java/com/ericsson/gerrit/plugins/eventslog/sql/SQLQueryMaker.java

diff --git a/src/main/java/com/ericsson/gerrit/plugins/eventslog/sql/SQLQueryMaker.java b/src/main/java/com/ericsson/gerrit/plugins/eventslog/sql/SQLQueryMaker.java
index aadf455..b01de71 100644
--- a/src/main/java/com/ericsson/gerrit/plugins/eventslog/sql/SQLQueryMaker.java
+++ b/src/main/java/com/ericsson/gerrit/plugins/eventslog/sql/SQLQueryMaker.java
@@ -37,10 +37,10 @@
   private static final int TWO = 2;
   private static final String TIME_ONE = "t1";
   private static final String TIME_TWO = "t2";
-  private static final DateFormat DATE_TIME_FORMAT = new SimpleDateFormat(
-      "yyyy-MM-dd HH:mm:ss");
-  private static final DateFormat DATE_ONLY_FORMAT = new SimpleDateFormat(
-      "yyyy-MM-dd");
+  private static final ThreadLocal<DateFormat> DATE_TIME_FORMAT = ThreadLocal
+      .withInitial(() -> new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"));
+  private static final ThreadLocal<DateFormat> DATE_ONLY_FORMAT = ThreadLocal
+      .withInitial(() -> new SimpleDateFormat("yyyy-MM-dd"));
 
   private final int returnLimit;
 
@@ -63,8 +63,8 @@
     }
     return String.format(
         "SELECT * FROM %s WHERE %s BETWEEN '%s' and '%s' LIMIT %d", TABLE_NAME,
-        DATE_ENTRY, DATE_TIME_FORMAT.format(dates[0]),
-        DATE_TIME_FORMAT.format(dates[1]), returnLimit);
+        DATE_ENTRY, DATE_TIME_FORMAT.get().format(dates[0]),
+        DATE_TIME_FORMAT.get().format(dates[1]), returnLimit);
   }
 
   @Override
@@ -92,9 +92,9 @@
   private Date parseDate(String date) throws ParseException {
     Date parsedDate;
     try {
-      parsedDate = DATE_TIME_FORMAT.parse(date);
+      parsedDate = DATE_TIME_FORMAT.get().parse(date);
     } catch (ParseException e) {
-      parsedDate = DATE_ONLY_FORMAT.parse(date);
+      parsedDate = DATE_ONLY_FORMAT.get().parse(date);
     }
     return parsedDate;
   }