Protect public methods against missing parameters
Change-Id: I1fec98233b9cab2248a6e6c6ba059892ff1b788f
Signed-off-by: Michael Ochmann <michael.ochmann@sap.com>
diff --git a/src/main/java/com/googlesource/gerrit/plugins/cfoauth/CFOAuthService.java b/src/main/java/com/googlesource/gerrit/plugins/cfoauth/CFOAuthService.java
index cad17eb..ee919cb 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/cfoauth/CFOAuthService.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/cfoauth/CFOAuthService.java
@@ -60,11 +60,17 @@
@Override
public OAuthToken getAccessToken(OAuthVerifier rv) {
+ if (rv == null || rv.getValue() == null) {
+ throw new UAAClientException("Must provide an authorization code");
+ }
return getAsOAuthToken(uaaClient.getAccessToken(rv.getValue()));
}
@Override
public OAuthUserInfo getUserInfo(OAuthToken token) throws IOException {
+ if (token == null) {
+ throw new UAAClientException("Must provide an access token");
+ }
AccessToken accessToken = uaaClient.toAccessToken(token.getToken());
UserInfo userInfo = accessToken.getUserInfo();
userInfo.setDisplayName(uaaClient.getDisplayName(token.getToken()));