WorkQueue: Improve task thread names
The RunnableScheduledFuture task inside a Task has a few layers that
don't help provide a meaningful thread name whereas the Task itself
often has a toString() that does, so use the Task itself.
Here's an example for a SendEmail thread. It's a similar result for
Index-Interactive and other threads.
Before (line breaks added by me):
SendEmail-1[
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@57310449[
Not completed,
task = java.util.concurrent.Executors$RunnableAdapter@3a7a2870[
Wrapped task = com.google.gerrit.server.logging.LoggingContextAwareRunnable@9252ca5
]
]
]
After:
SendEmail-1[send-email comments]
Change-Id: Iea78b6412b2259a968eed0a16744638f87796d91
Release-Notes: Improved WorkQueue task thread names
(cherry picked from commit d4c1e0a6ed7eb2b8fffa078a7ccec0c0edb0e668)
diff --git a/java/com/google/gerrit/server/git/WorkQueue.java b/java/com/google/gerrit/server/git/WorkQueue.java
index 86d6c7c..ce2d5b6 100644
--- a/java/com/google/gerrit/server/git/WorkQueue.java
+++ b/java/com/google/gerrit/server/git/WorkQueue.java
@@ -695,7 +695,7 @@
try {
executor.onStart(this);
runningState.set(State.RUNNING);
- Thread.currentThread().setName(oldThreadName + "[" + task.toString() + "]");
+ Thread.currentThread().setName(oldThreadName + "[" + this + "]");
task.run();
} finally {
Thread.currentThread().setName(oldThreadName);
