gitindex: remove ignoreMissingSubmodules field
ignoreMissingSubmodules is always true, so we can remove it.
Change-Id: I42ffef55300a063d2bb502a2eae8f47c4f001706
diff --git a/gitindex/tree.go b/gitindex/tree.go
index b8f1a81..f44104d 100644
--- a/gitindex/tree.go
+++ b/gitindex/tree.go
@@ -43,9 +43,6 @@
// Path => commit SHA1
subRepoVersions map[string]plumbing.Hash
repoCache *RepoCache
-
- // If set, don't gasp on missing submodules.
- ignoreMissingSubmodules bool
}
// subURL returns the URL for a submodule.
@@ -66,12 +63,11 @@
func newRepoWalker(r *git.Repository, repoURL string, repoCache *RepoCache) *repoWalker {
u, _ := url.Parse(repoURL)
return &repoWalker{
- repo: r,
- repoURL: u,
- tree: map[fileKey]BlobLocation{},
- repoCache: repoCache,
- subRepoVersions: map[string]plumbing.Hash{},
- ignoreMissingSubmodules: true,
+ repo: r,
+ repoURL: u,
+ tree: map[fileKey]BlobLocation{},
+ repoCache: repoCache,
+ subRepoVersions: map[string]plumbing.Hash{},
}
}
@@ -121,12 +117,9 @@
}
func (r *repoWalker) tryHandleSubmodule(p string, id *plumbing.Hash) error {
- err := r.handleSubmodule(p, id)
- if r.ignoreMissingSubmodules && err != nil {
+ if err := r.handleSubmodule(p, id); err != nil {
log.Printf("submodule %s: ignoring error %v", p, err)
- err = nil
}
-
return nil
}