commit c4fbd5700d8556d2ea3d199ac00458a8bc9e420b
author Paladox none <thomasmulhall410@yahoo.com> Sat Oct 05 22:26:29 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Sat Oct 05 22:26:29 2019 +0000
tree 8e0dc841e1bcc1072af1dbfbbd03032ae187e734
parent c5ad3dc967a25ac28c6c30593c527f9c5aff51cf
parent 192670e6302523848b9391f3bea2d025e7061298

Merge "Remove _legacyUndefinedCheck"

src/main/resources/static/zuul-status-view.js

diff --git a/src/main/resources/static/zuul-status-view.js b/src/main/resources/static/zuul-status-view.js
index 4d0c3e2..2073f78 100644
--- a/src/main/resources/static/zuul-status-view.js
+++ b/src/main/resources/static/zuul-status-view.js
@@ -184,8 +184,6 @@
      * @return {Promise} Resolves to a fetch Response object.
      */
     async getZuulStatus(change, revision) {
-      if (!change || !revision) return [];
-
       const response = await this._getReponse(change, revision);
 
       if (response && response.status && response.status === 200) {
@@ -204,6 +202,8 @@
      * @return {Promise} Resolves to a fetch Response object.
      */
     async _getReponse(change, revision) {
+      if (!change || !revision) return false;
+
       const url = this.zuulTenant === null ?
         `${this.zuulUrl}${change._number},${revision._number}` :
         `${this.zuulUrl}/api/tenant/${this.zuulTenant}/status/change/${change._number},${revision._number}`;