commit 7e931b895ee80b8daf179a939aeb14d9c03b7246
author Edwin Kempin <edwin.kempin@sap.com> Wed Nov 26 09:36:04 2014 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Nov 26 09:36:04 2014 +0000
tree d5ad966a832f78b1e6f02bf60395d165799ff556
parent c5fef1198b2d7f0d1868d3dc0ea44408aba8a1f5
parent 0572b80a44d6fe805babc28ddfa54fd262a4c9d3

Merge "Refactor XDocServlet: Validate request method in helper method"

src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocServlet.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocServlet.java b/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocServlet.java
index e281ef3..40ce348 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocServlet.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocServlet.java
@@ -23,6 +23,7 @@
 import com.google.common.net.HttpHeaders;
 import com.google.gerrit.extensions.restapi.AuthException;
 import com.google.gerrit.extensions.restapi.IdString;
+import com.google.gerrit.extensions.restapi.MethodNotAllowedException;
 import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
 import com.google.gerrit.httpd.resources.Resource;
 import com.google.gerrit.httpd.resources.SmallResource;
@@ -106,37 +107,33 @@
   @Override
   public void service(HttpServletRequest req, HttpServletResponse res)
       throws IOException {
-    if (!"GET".equals(req.getMethod()) && !"HEAD".equals(req.getMethod())) {
-      CacheHeaders.setNotCacheable(res);
-      res.sendError(HttpServletResponse.SC_METHOD_NOT_ALLOWED);
-      return;
-    }
+    try {
+      validateRequestMethod(req);
 
-    ResourceKey key = ResourceKey.fromPath(req.getPathInfo());
-    ProjectState state = projectCache.get(key.project);
-    if (state == null) {
-      Resource.NOT_FOUND.send(req, res);
-      return;
-    }
-    XDocProjectConfig cfg = cfgFactory.create(state);
-    if (key.file == null) {
-      res.sendRedirect(getRedirectUrl(req, key, cfg));
-      return;
-    }
-
-    MimeType mimeType = fileTypeRegistry.getMimeType(key.file, null);
-    FormatterProvider formatter;
-    if (req.getParameter("raw") != null) {
-      formatter = formatters.getRawFormatter();
-    } else {
-      formatter = formatters.get(state, key.file);
-      if (formatter == null && !isSafeImage(mimeType)) {
+      ResourceKey key = ResourceKey.fromPath(req.getPathInfo());
+      ProjectState state = projectCache.get(key.project);
+      if (state == null) {
         Resource.NOT_FOUND.send(req, res);
         return;
       }
-    }
+      XDocProjectConfig cfg = cfgFactory.create(state);
+      if (key.file == null) {
+        res.sendRedirect(getRedirectUrl(req, key, cfg));
+        return;
+      }
 
-    try {
+      MimeType mimeType = fileTypeRegistry.getMimeType(key.file, null);
+      FormatterProvider formatter;
+      if (req.getParameter("raw") != null) {
+        formatter = formatters.getRawFormatter();
+      } else {
+        formatter = formatters.get(state, key.file);
+        if (formatter == null && !isSafeImage(mimeType)) {
+          Resource.NOT_FOUND.send(req, res);
+          return;
+        }
+      }
+
       ProjectControl projectControl = projectControlFactory.validateFor(key.project);
       String rev = key.revision;
       if (rev == null) {
@@ -212,7 +209,9 @@
     } catch (RepositoryNotFoundException | NoSuchProjectException
         | ResourceNotFoundException | AuthException | RevisionSyntaxException e) {
       Resource.NOT_FOUND.send(req, res);
-      return;
+    } catch (MethodNotAllowedException e) {
+      CacheHeaders.setNotCacheable(res);
+      res.sendError(HttpServletResponse.SC_METHOD_NOT_ALLOWED);
     }
   }
 
@@ -251,6 +250,13 @@
     }
   }
 
+  private static void validateRequestMethod(HttpServletRequest req)
+      throws MethodNotAllowedException {
+    if (!("GET".equals(req.getMethod()) || "HEAD".equals(req.getMethod()))) {
+      throw new MethodNotAllowedException();
+    }
+  }
+
   private boolean isSafeImage(MimeType mimeType) {
     return isImage(mimeType) && fileTypeRegistry.isSafeInline(mimeType);
   }