commit 4b740e6c337928a120aa4313bd71bcdad105400e
author Luca Milanesio <luca.milanesio@gmail.com> Wed Jan 26 23:36:48 2022 +0000
committer Luca Milanesio <luca.milanesio@gmail.com> Thu Jan 27 00:10:46 2022 +0000
tree bfe4488b6fc5a1cd9591c580d2dcb16d96452e47
parent 823bff0d9268abb6b28cef7d8d9f42a0f1b69d24

Remove listFiles() and rely on stream for reading sessions to asMap()

asMap() isn't calling listFiles() anymore and is instead relying on
the standard Java Stream-to-Map conversion, which isn't using the
additional memory footprint of the list of Paths.

Change-Id: Iaaa4c1bf5e39bf50100da222a9b719647cc702fc

src/main/java/com/googlesource/gerrit/plugins/websession/flatfile/FlatFileWebSessionCache.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/websession/flatfile/FlatFileWebSessionCache.java b/src/main/java/com/googlesource/gerrit/plugins/websession/flatfile/FlatFileWebSessionCache.java
index a89e202..b467614 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/websession/flatfile/FlatFileWebSessionCache.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/websession/flatfile/FlatFileWebSessionCache.java
@@ -35,16 +35,15 @@
 import java.time.Clock;
 import java.time.Instant;
 import java.time.ZoneId;
-import java.util.ArrayList;
-import java.util.List;
+import java.util.AbstractMap.SimpleImmutableEntry;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.UUID;
 import java.util.concurrent.Callable;
-import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;
 import java.util.concurrent.ExecutionException;
 import java.util.function.Consumer;
+import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import java.util.stream.StreamSupport;
 
@@ -87,14 +86,12 @@
 
   @Override
   public ConcurrentMap<String, Val> asMap() {
-    ConcurrentMap<String, Val> map = new ConcurrentHashMap<>();
-    for (Path path : listFiles()) {
-      Val v = readFile(path);
-      if (v != null) {
-        map.put(path.getFileName().toString(), v);
-      }
-    }
-    return map;
+    return sessionStream()
+        .map(path -> new SimpleImmutableEntry<>(path.getFileName().toString(), readFile(path)))
+        .filter(entry -> entry.getValue() != null)
+        .collect(
+            Collectors.toConcurrentMap(
+                SimpleImmutableEntry::getKey, SimpleImmutableEntry::getValue));
   }
 
   @Override
@@ -228,18 +225,6 @@
     }
   }
 
-  private List<Path> listFiles() {
-    List<Path> files = new ArrayList<>();
-    try (DirectoryStream<Path> dirStream = sessionDirectoryStream()) {
-      for (Path path : dirStream) {
-        files.add(path);
-      }
-    } catch (IOException e) {
-      log.atSevere().withCause(e).log("Cannot list files in cache %s", websessionsDir);
-    }
-    return files;
-  }
-
   private void foreachSession(Consumer<Path> sessionPath) {
     try (DirectoryStream<Path> dirStream = sessionDirectoryStream()) {
       dirStream.forEach(sessionPath);