)]}'
{
  "commit": "e172a6da9dc6438d03e8870d23ad391721c6e911",
  "tree": "4e144534cdc97a664b5b4fca4668e5596a841546",
  "parents": [
    "f8fc46fa0c234eabed49da815a104ed742cffa55"
  ],
  "author": {
    "name": "Alice Kober-Sotzek",
    "email": "aliceks@google.com",
    "time": "Thu Aug 20 16:03:33 2020 +0200"
  },
  "committer": {
    "name": "Alice Kober-Sotzek",
    "email": "aliceks@google.com",
    "time": "Thu Aug 20 16:05:41 2020 +0200"
  },
  "message": "Avoid any uses or lookups of ffmpeg by Tika\n\nI75d8b85d7 reintroduced a dependency on Tika to fix an issue. Switching\nback to Tika introduces another issue, though. On startup, Tika reaches\nout to the local system to find out whether ffmpeg is installed, which\nit will then automatically use as parser. Depending on the environment\nthe uploadvalidator plugin is run, this lookup of ffmpeg on the local\nsystem might not be permitted.\n\nThere are two options to avoid this lookup of ffmpeg:\n1) Use a custom Tika config which excludes ExternalParser (which is\nresponsible for the ffmpeg lookup).\n2) Directly use the default detector of Tika as we don\u0027t need the parser\nfunctionality anyway.\n\nIn this change, we went with 2). For 1), we would have needed to\nidentify which exact configuration we\u0027re currently using. With 2),\nwe\u0027re also safe to not introduce a regression if we change the config\nwithout further considerations in the future.\n\nA third option would be to remove the Tika dependency but compared to\nthat, this change seems like a better option.\n\nChange-Id: I76ec0c488f93e4a9c71f0527895acbc798c5a9ba\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "67ae2896030f20c21f8bd744fb1e8fc54c8fce89",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/ContentTypeUtil.java",
      "new_id": "6e6ad982fec247542f7c4f2a545b8367811eb8d9",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/ContentTypeUtil.java"
    },
    {
      "type": "modify",
      "old_id": "ac38404c89986905a32615c4b17e5265a0fc9a5b",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/uploadvalidator/MimeTypeDetection.java",
      "new_id": "eb3820f29689c9d1a8b0d29560c193a4e010ff67",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/uploadvalidator/MimeTypeDetection.java"
    }
  ]
}
