)]}' { "commit": "af4ac388d6ea93237c1c5cf424c77ec3d995bcf8", "tree": "d817530e455825bea3bfc6bf00ce568c73b78143", "parents": [ "be4d31908ff7dd24bbcab433dc58b8b26bf417b4" ], "author": { "name": "Maxime Guerreiro", "email": "maximeg@google.com", "time": "Wed May 02 13:50:28 2018 +0000" }, "committer": { "name": "Maxime Guerreiro", "email": "maximeg@google.com", "time": "Wed May 02 17:04:40 2018 +0000" }, "message": "Cleanup classes\n\nRemove the complicated constructor SimpleSubmitRulesModule,\nit is error-prone and Guice might not be entirely ready at this\npoint.\n\nRemove #getConfig, which was only used once from\nNoUnresolvedCommentsRule. Directly call the right method.\n\nQualify sub-classes imports.\n\nChange-Id: Ic5a6a4875861279ae237ca6438adf5fd7694a29e\n", "tree_diff": [ { "type": "modify", "old_id": "821f79413f3d086854ab6fa57278a6f01518e35d", "old_mode": 33188, "old_path": "src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/SimpleSubmitRulesModule.java", "new_id": "874f6d5d5320db1546c920da702af691d07023ac", "new_mode": 33188, "new_path": "src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/SimpleSubmitRulesModule.java" }, { "type": "modify", "old_id": "468969b53e8eb1e8e4651bcf778ac07332803743", "old_mode": 33188, "old_path": "src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/config/ConfigServlet.java", "new_id": "bedff8d4432d5e8c6b3b7dd94edb52f60b349e6f", "new_mode": 33188, "new_path": "src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/config/ConfigServlet.java" }, { "type": "modify", "old_id": "20712a9fbc19236b53a75993f2814e1c45defc83", "old_mode": 33188, "old_path": "src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/config/SubmitConfig.java", "new_id": "9c05ffca734944a99c9097baaf1b21e946844c2c", "new_mode": 33188, "new_path": "src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/config/SubmitConfig.java" }, { "type": "modify", "old_id": "671278210e3a917085095b16a72b9e9795a50cb2", "old_mode": 33188, "old_path": "src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/NoUnresolvedCommentsRule.java", "new_id": "bd6451c0f13e7e8a0d9873ceeccead7bdfef1d0d", "new_mode": 33188, "new_path": "src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/NoUnresolvedCommentsRule.java" }, { "type": "modify", "old_id": "d1f4f45d005fb923c589dc5aa3d78cd8be443404", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/AbstractSimpleSubmitRulesIT.java", "new_id": "e73172fe57a5d04271edb9bebe23a27b35e3784d", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/AbstractSimpleSubmitRulesIT.java" }, { "type": "modify", "old_id": "6b1e2bac0dbc0a7c53f86174a510d14b5e9892e5", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/config/ConfigServletIT.java", "new_id": "e83b0e9713390fafdd9002e78426caa308cdb6f8", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/config/ConfigServletIT.java" }, { "type": "modify", "old_id": "f3b95ca9b73330ac8666504640d26541e9cabe0e", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/config/ConfigTranslatorTest.java", "new_id": "332afb56f06e04dba3728c59a3f49e8e06ead490", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/config/ConfigTranslatorTest.java" }, { "type": "modify", "old_id": "3ae48f1f9a49cf03dbb7eee56a4a43172fd594c0", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/NoUnresolvedCommentsRuleIT.java", "new_id": "8e80861d9aa24933bdd58bac3a99d173765ec945", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/NoUnresolvedCommentsRuleIT.java" }, { "type": "modify", "old_id": "b1e0082950ca0acac57ebe71ba922896aad5fb65", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/RequireNonAuthorApprovalRuleTest.java", "new_id": "7324f55e28bcb7c58b12093959dab7ee4b2a482e", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/RequireNonAuthorApprovalRuleTest.java" } ] }