)]}'
{
  "commit": "d68420f80a3236ce5da9f021b1bc90f97cc8ce24",
  "tree": "22399137d25e8d6f80a9211e8b047cd7eb995bd1",
  "parents": [
    "079484a34d6724bd21ad5c717f286f338c58eef0"
  ],
  "author": {
    "name": "Patrick Hiesel",
    "email": "hiesel@google.com",
    "time": "Wed Feb 01 09:12:52 2023 +0100"
  },
  "committer": {
    "name": "Patrick Hiesel",
    "email": "hiesel@google.com",
    "time": "Wed Feb 01 10:57:43 2023 +0000"
  },
  "message": "Ignore account visibility when processing reviewers\n\nThe reviewers plugin allows project owners to configure a list\nof accounts and groups that should be added as reviewers. The logic\nthat actually adds reviewers is triggered e.g. on change updates.\n\nWe used to check account visibility against the calling user (the user\nwho updated the change) which conceptually makes no sense because\nthe project owner provided this list. Next to the conceptual mistake\nthat we get a good number of bug reports for, checking account\nvisibility here is also very slow. We saw traces where it took\n10s of seconds.\n\nThis commit makes checking account visibility dependent on what we do:\n  - For suggesting reviewers, we keep the visibility check\n  - For processing updates, we drop it\n\nGoogle-Bug-Id: b/267202984\nChange-Id: I39023f74e7cfbdab24b7abd3df6518e0b2a4b209\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "06a365f7894eeb26f1c369f3516cb181d58ed3fe",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewerSuggest.java",
      "new_id": "088d30437125a612f6696c79199c870f108cc41a",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewerSuggest.java"
    },
    {
      "type": "modify",
      "old_id": "865c2895758f0dca096c6210c46973477e831b4d",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/reviewers/Reviewers.java",
      "new_id": "aaf7c36962bcadca45d91aec3dbd22c4feca7c17",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/reviewers/Reviewers.java"
    },
    {
      "type": "modify",
      "old_id": "ea7d8e1465ad7ff7c725e014fc324b29254b308d",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolver.java",
      "new_id": "94544557d0a5562e946126b0ddc7b27bbef20d78",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolver.java"
    },
    {
      "type": "modify",
      "old_id": "65e72e52598b2ac46db81972311d60077cd0b19c",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/reviewers/ReviewersIT.java",
      "new_id": "e6fb981de4613c7067f50d2200c7e932515d99bb",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/reviewers/ReviewersIT.java"
    },
    {
      "type": "modify",
      "old_id": "607c9f50ae23fad009cff3a05d0da4c477982667",
      "old_mode": 33188,
      "old_path": "src/test/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolverIT.java",
      "new_id": "76d5b2b1ac9e67c6e35b3b5a2428f6ff140dafb8",
      "new_mode": 33188,
      "new_path": "src/test/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolverIT.java"
    }
  ]
}
