)]}' { "commit": "f0fb23cdf39dfb89971e6655f0e08650e14b0631", "tree": "580d8d9da90e9e2c7bc9c26222869cd7cd203d88", "parents": [ "739be77f0037317ae64041125b2290aa6f012467" ], "author": { "name": "Luca Milanesio", "email": "luca.milanesio@gmail.com", "time": "Tue Jun 30 17:39:41 2020 +0100" }, "committer": { "name": "Luca Milanesio", "email": "luca.milanesio@gmail.com", "time": "Wed Jul 01 14:19:11 2020 +0000" }, "message": "Fix flakiness in ReplicationIT for pending events firing\n\nFix the shouldFirePendingOnlyToStoredUri test by making sure\nthat events are NOT executed by the replication engine until\nthe tests has completed the preparation phase.\n\nThe Gerrit build on stable-2.16 became flaky right afterward\nthe merge of the new shouldFirePendingOnlyToStoredUri test which\nhighlighted the flakiness.\n\nThe test wants to simulate a situation where a ref-update needs\nto be propagated to two remotes: remote1 and remote2.\nFor doing so, it configures the two remotes and crates a change\nfor generating the two replication tasks files on the filesystem.\nThen, it looks for the events associated for remote1 and removes\nthem, so that the next replication queue startup won\u0027t find it\nand won\u0027t replicate the change to remote1.\n\nDuring the interval of time between the creation of the change\nand the removal of the underlying replication task on the filesystem,\nthe replication task could have been executed already and the\ntest failed.\n\nMake sure that the replication does not kick in by\nsetting the replication timeout to Integer.MAX_VALUE at the\nbeginning. Then, once the replication task file is removed on the\nfilesystem, set it back to default and reload the configuration to\ntrigger the firing of the events.\n\nRemove also the explicit start/stop of the replication queue, as\nthe config reload is already a stop/start process and it\nautomatically triggering an event replay.\n\nChange-Id: Ifd591da37e94b6ce8f281cb0404f3f3c737489f3\n", "tree_diff": [ { "type": "modify", "old_id": "aa15e3afcb480e97d084aebf0dc0370c8382183f", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationIT.java", "new_id": "8da9da2216c235ef1cb960c17d6826835de02883", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationIT.java" } ] }