)]}'
{
  "commit": "aba8c72aaf29d0ece59779dc59e4ed6e97c401a0",
  "tree": "2ab0d3f2a9bf264e892c1b8295724aed26ae1285",
  "parents": [
    "902b60ed3ce34b63b41c454f4cdfeb61f0310a90"
  ],
  "author": {
    "name": "Saša Živkov",
    "email": "sasa.zivkov@sap.com",
    "time": "Fri Oct 12 14:21:38 2018 +0200"
  },
  "committer": {
    "name": "David Pursehouse",
    "email": "dpursehouse@collab.net",
    "time": "Wed Jul 31 23:53:27 2019 +0000"
  },
  "message": "Consistently handle remote repository creation failures\n\nFailure to create remote repository was handled inconsistently in the\nthree existing AdminApi implementations. This issue was present in the\ncode even before the refactoring done in\nIe760bf3e143b1d143b6e81ac6cfa816ef1f8d016. For example, creation of\nremote repository over SSH [1] didn\u0027t return a status back to the\ncaller, while the Gerrit+SSH implementation [2] did return a boolean\nflag which was afterwards ignored by the caller [3].\n\nNot handling remote repository creation failures had an ugly effect:\nwe log the \"Missing repository created; ...\" [4], even if the repository\ncreation failed.\n\nLet all three implementations of the AdminApi return a flag indicating\nthe success/failure and make sure to handle it properly.\n\nFurther, remove some redundant and potentially confusing parts of the\nlog messages as they assume that failure to create missing repository\ncan only be caused by using wrong protocol.\n\n[1] https://gerrit.googlesource.com/plugins/replication/+/d557ccc642c59a55750f560ce0d98870e1550d65/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java#290\n[2] https://gerrit.googlesource.com/plugins/replication/+/d557ccc642c59a55750f560ce0d98870e1550d65/src/main/java/com/googlesource/gerrit/plugins/replication/GerritSshApi.java#43\n[3] https://gerrit.googlesource.com/plugins/replication/+/d557ccc642c59a55750f560ce0d98870e1550d65/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java#259\n[4] https://gerrit.googlesource.com/plugins/replication/+/092792edacf9c29732a560a30967b92664cd65f9/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java#400\n\nChange-Id: I6566f867138ab73c81ff7a67630772c3734e501b\n(cherry picked from commit b95d921d6db891dc724f619d957ab35e634f7e44)\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ef7e353a32c1213b6a85312e5946679cdb18df51",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/replication/AdminApi.java",
      "new_id": "79362fd9f5644968879c275131b3270a7570439d",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/replication/AdminApi.java"
    },
    {
      "type": "modify",
      "old_id": "85b17d04b16b32d93a2d690863045d6495dd998f",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/replication/GerritSshApi.java",
      "new_id": "0b439cc9fd202bfe3c86eca8ebc6f632c9f612c3",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/replication/GerritSshApi.java"
    },
    {
      "type": "modify",
      "old_id": "1012cd7f206f1c4cdc92df36b71bb2825453abe8",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/replication/LocalFS.java",
      "new_id": "908e7e0dfd70d1e5d636a9fabea2d468ac095fa3",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/replication/LocalFS.java"
    },
    {
      "type": "modify",
      "old_id": "73940a2c0d06b83c07df005d20e327f478d4fb27",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java",
      "new_id": "293701a3e5eb3d1c2d3214c0cf4e068695c109fb",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java"
    },
    {
      "type": "modify",
      "old_id": "dad1b0b3a8f64826038743cfe1b25330ffe1a3f6",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/replication/RemoteSsh.java",
      "new_id": "6dfa11751f6fc188ab942013ac2f3871efc52340",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/replication/RemoteSsh.java"
    },
    {
      "type": "modify",
      "old_id": "541a5953ba0463943f35624bc890c90fad1ef8c3",
      "old_mode": 33188,
      "old_path": "src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java",
      "new_id": "03b7ad2087cbc04599ccdfb2dceb509c706e10a3",
      "new_mode": 33188,
      "new_path": "src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java"
    }
  ]
}