)]}' { "commit": "956fbbc9956aeba435d20267849b00466da48d1b", "tree": "91dd8637263d653ca29bbd601c1c4659b9840f9e", "parents": [ "f3ba97ee840a21ff697127b53bd4dbea6795a35b" ], "author": { "name": "Nasser Grainawi", "email": "nasser@codeaurora.org", "time": "Thu Aug 20 14:59:30 2020 -0600" }, "committer": { "name": "Nasser Grainawi", "email": "nasser@codeaurora.org", "time": "Mon Aug 31 15:20:44 2020 -0600" }, "message": "ReplicationTasksStorage: Remove test-only list* methods\n\nTests should be accurate enough to list from the correct storage areas.\nIf tests aren\u0027t accurate enough when doing so, then the tests should be\nimproved to provide that accuracy.\n\nThe updated ReplicationIT and ReplicationFanoutIT tests should be\ninvestigated in a follow up as tests that currently have an ambiguous\nexpected state for tasks. For now, they\u0027re worked around by considering\nboth running and waiting tasks. As integration tests, these tests\nshould be fixed to test behavior, not the specific implementation of\nthe storage layer.\n\nPartially reverts Ie164b03579cc917f1095cfde6d77cab630f77759.\n\nChange-Id: I021ad40e35e9f1c9d7076bb6984c864743be829f\n", "tree_diff": [ { "type": "modify", "old_id": "36c9c98071896f11269e44a3a5881335f3cf97cf", "old_mode": 33188, "old_path": "src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationTasksStorage.java", "new_id": "048767f89f1cb6e924f5172e78be61fcde2b3319", "new_mode": 33188, "new_path": "src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationTasksStorage.java" }, { "type": "modify", "old_id": "adb7fc820a26ba911e1a366f7bfab81016ab5c02", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationFanoutIT.java", "new_id": "f06b933226668dc55bfa9a3fab0eb317079c61d0", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationFanoutIT.java" }, { "type": "modify", "old_id": "106078051142aa005c20d9767def3d00565a3105", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationIT.java", "new_id": "bfabc9f8401cdc16efe88d1ee06e4fba7ef8d9f6", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationIT.java" }, { "type": "modify", "old_id": "d69ace02e3f8265ea849a141bd8e605415ac7a8e", "old_mode": 33188, "old_path": "src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationTasksStorageTest.java", "new_id": "211eb34ac65c5b2fbfbfe85cf60031834addf3d0", "new_mode": 33188, "new_path": "src/test/java/com/googlesource/gerrit/plugins/replication/ReplicationTasksStorageTest.java" } ] }