tree 51153b659f080a95ba95fd704958a6a31bca5fd7
parent 0df288afccb53b7abbe4f2ee90f68c80e9dcd2c7
author Luca Milanesio <luca.milanesio@gmail.com> 1563461568 +0000
committer Luca Milanesio <luca.milanesio@gmail.com> 1563493524 +0000

Revert "Remove replication event from pending when runway is allowed"

This reverts commit e780ae61cbbba3f88558a3620065d1fcdc0768c8.

Reason for revert: Creates potentially infinite Heap consumption and
JVM crash when a PushOp is denied to use the runway.

The problem is caused by the late removal of the PushOp from the
list of pending operations, which causes the subsequent reschedule
to find the same operation and double the number of replication states
associated with it. If the loop happens multiple times, the generated
consumption grows exponentially causing the JVM to enter a series
of continuous stop-the-world GC that eventually lead to complete
block of the JVM activity.

The method `requestRunway` is thus not telling the truth because
it is actually relying on the fact that the PushOne operation is
removed also from the pending list, independently from its runway
concession status.

Change-Id: I6097bc7ad16c8bcc86a7d30af7d2ad331728712d